[GitHub] [pulsar] oversearch commented on issue #11632: [C++] pulsar-client-cpp stability enhancements and code cleanup

[GitBox <gi...@apache.org>]

oversearch commented on issue #11632:
URL: https://github.com/apache/pulsar/issues/11632#issuecomment-897818966


   Thanks for the feedback guys.  I'll proceed with the changes as time allows, starting with the improved warnings.
   
   With respect to the boost compatibility stuff: you're quite right that it's tricky, and I understand your desire to drop support for older versions (especially those from the pre-C++11 era).  I'm have no intention to change the preferred boost version in the CI suite.  
   
   My company's codebase is a bit of an aberration - it's over 20 years old, and is a >3M line monorepo, so things like upgrading boost is a major undertaking, and 3rd-party library integration is difficult.  I certainly don't expect to make this thing out-of-the-box compatible with that sort of setup, but rather I simply want to reduce the friction where it's easy.  To make this project compile for our code base under boost 1.41 there were a few cases where I had to go to such lengths as including "patch" headers from newer boost versions.  Obviously there's nothing we can do here about completely missing functionality like that.
   
   I'll limit any boost related changes to only simple things that I can cleanly fix by `#ifdef`ing code blocks to specific versions.  There's a least a few places where doing that can extend boost support back a few versions, which I think would be generally helpful without disturbing anything else.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org