[jira] [Commented] (ACCUMULO-1169) Can't build against CDH3U5

["Keith Turner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-1169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599088#comment-13599088 ] 

Keith Turner commented on ACCUMULO-1169:
----------------------------------------

instead of reflection, we could catch Exception instead of IOException.  If recover lease fails, it fall through and tried to write nothing to the file.


                
> Can't build against CDH3U5
> --------------------------
>
>                 Key: ACCUMULO-1169
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1169
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: tserver
>    Affects Versions: 1.5.0
>         Environment: branch 1.5
>            Reporter: Josh Elser
>            Assignee: Keith Turner
>            Priority: Critical
>
> I tried to compile 1.5 against CDH3U5 recently and noticed that I could no longer do so due to a change in server/o.a.a.s.m.r.HadoopLogCloser.
> In CDH3U5, DistributedFileSystem#recoverLease(Path) throws IOException *and* NoSuchMethodException, whereas 0.20.205, 1.0.4, 1.1.0, and 2.0.3-ALPHA (I believe that was the list I checked; regardless, a large majority of Apache Hadoop releases).
> I believe we could do some reflection magic here to catch when the underlying DistributedFileSystem throws the additional exception, and thus know when we have to catch it.
> It would be nice to have this in for 1.5 to support customers who want to use CDH3, but I can understand objections to putting work-arounds in for non-Apache Hadoop versions.
> I'll also try to get a patch together today for this if no one beats me to it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira