You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hvanhovell (via GitHub)" <gi...@apache.org> on 2023/07/25 00:26:29 UTC
[GitHub] [spark] hvanhovell opened a new pull request, #42140: [SPARK-44535][CONNECT][SQL] Move required Streaming API to sql/api
hvanhovell opened a new pull request, #42140:
URL: https://github.com/apache/spark/pull/42140
### What changes were proposed in this pull request?
This PR moves a bunch streaming classed to the SQL/API project.
### Why are the changes needed?
This is needed to disconnect the Spark Connect Scala Client from catalyst.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing Tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #42140: [SPARK-44535][CONNECT][SQL] Move required Streaming API to sql/api
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #42140:
URL: https://github.com/apache/spark/pull/42140#issuecomment-1648794801
@rangadi PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rangadi commented on a diff in pull request #42140: [SPARK-44535][CONNECT][SQL] Move required Streaming API to sql/api
Posted by "rangadi (via GitHub)" <gi...@apache.org>.
rangadi commented on code in PR #42140:
URL: https://github.com/apache/spark/pull/42140#discussion_r1273397499
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryListener.scala:
##########
@@ -116,7 +115,7 @@ object StreamingQueryListener extends Serializable {
* @since 3.5.0
*/
@Evolving
- trait Event extends SparkListenerEvent
+ trait Event
Review Comment:
@bogao007 PTAL this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #42140: [SPARK-44535][CONNECT][SQL] Move required Streaming API to sql/api
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #42140:
URL: https://github.com/apache/spark/pull/42140#issuecomment-1650941443
Merging this. Python tests are known to be flaky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell closed pull request #42140: [SPARK-44535][CONNECT][SQL] Move required Streaming API to sql/api
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell closed pull request #42140: [SPARK-44535][CONNECT][SQL] Move required Streaming API to sql/api
URL: https://github.com/apache/spark/pull/42140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org