You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/10/19 22:46:13 UTC

[GitHub] [phoenix] joshelser commented on a change in pull request #796: PHOENIX-5066 The TimeZone is incorrectly used during writing or reading data

joshelser commented on a change in pull request #796:
URL: https://github.com/apache/phoenix/pull/796#discussion_r508105876



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java
##########
@@ -171,6 +172,13 @@
     private boolean isRunningUpgrade;
     private LogLevel logLevel;
     private Double logSamplingRate;
+    private static ThreadLocal<DateUtil> DateUtilContext

Review comment:
       Should be final? Follow code style of all caps for static+final variables, too.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org