[GitHub] [incubator-shardingsphere] cherrylzhao edited a comment on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid

[GitBox <gi...@apache.org>]

cherrylzhao edited a comment on issue #2967: Fixes #2010 :fix bug do not support connectionInitSqls config of druid
URL: https://github.com/apache/incubator-shardingsphere/pull/2967#issuecomment-528782601
 
 
   I think it can't work on a real [spring-boot-orchestration](https://github.com/apache/incubator-shardingsphere-example/tree/dev/sharding-jdbc-example/orchestration-example/orchestration-spring-boot-example) scenario, please verify it again, the key process look like this:
   
   1. DataSourceUtils parse yamlFile from classpath to create physical DataSource(e.g. Druid)
   2. convert DataSource to a DataSourceConfiguration for orchestration using.
   3. convert DataSourceConfiguration to a yaml string using YamlEngine.marshal()
   4. persist yaml string to register center(zookeeper)
   5. read yaml string from zk if necessary, then create DataSource using DataSourceConfiguration
   
   so you should make orchestration-example run in your local environment, then verify the result, if you have any problem please feel free to contact me.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services