You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/11/12 18:58:29 UTC

[GitHub] [avro] KalleOlaviNiemitalo commented on a diff in pull request #1956: AVRO-3670: Add NET 7.0 support

KalleOlaviNiemitalo commented on code in PR #1956:
URL: https://github.com/apache/avro/pull/1956#discussion_r1020794223


##########
lang/csharp/src/apache/benchmark/Avro.benchmark.csproj:
##########
@@ -31,6 +31,12 @@
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 
+  <PropertyGroup>
+    <!-- Some schemas use lower cased names, which causes some class names being lower case only -->
+    <!-- e.g. The type name 'test' only contains lower-cased ascii characters. Such names may become reserved for the language. -->
+    <NoWarn>$(NoWarn);CS8981</NoWarn>
+  </PropertyGroup>

Review Comment:
   Should change the code generator to emit all lowercase type names in `@identifier` format.  Has an issue been filed for that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org