You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Julian Reschke (Jira)" <ji...@apache.org> on 2026/07/09 14:49:00 UTC
[jira] [Assigned] (SLING-13260) Using a String instead of StrandardCharset to instantiante strings requires a lock
[ https://issues.apache.org/jira/browse/SLING-13260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke reassigned SLING-13260:
--------------------------------------
Assignee: Julian Reschke
> Using a String instead of StrandardCharset to instantiante strings requires a lock
> -----------------------------------------------------------------------------------
>
> Key: SLING-13260
> URL: https://issues.apache.org/jira/browse/SLING-13260
> Project: Sling
> Issue Type: Improvement
> Components: ResourceResolver
> Reporter: Patrique Legault
> Assignee: Julian Reschke
> Priority: Minor
>
> Under heavy load we see many threads locking with the following pattern [1].
> This happens because the [URI|https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/helper/URI.java#L4022] class passes a String for the Charset, this results in the String class calling java.lang.String.[lookup|https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/String.java#L1662-L1665] which locks in order to perform the lookup.
> A simple enhancement is to pass the Charset as such to prevent the [lookup|https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/String.java#L1690-L1692].
>
> [1]
> {code:java}
> java.lang.Thread.State: BLOCKED (on object monitor)
> at sun.nio.cs.StandardCharsets.charsetForName(java.base@21.0.10/StandardCharsets.java:1304)
> - waiting to lock <0x000000041005a680> (a sun.nio.cs.StandardCharsets)
> at java.nio.charset.Charset.lookup2(java.base@21.0.10/Charset.java:486)
> at java.nio.charset.Charset.lookup(java.base@21.0.10/Charset.java:475)
> at java.nio.charset.Charset.forName(java.base@21.0.10/Charset.java:539)
> at java.lang.String.lookupCharset(java.base@21.0.10/String.java:848)
> at java.lang.String.<init>(java.base@21.0.10/String.java:1390)
> at org.apache.sling.resourceresolver.impl.helper.URI.getAsciiString(URI.java:4022)
> at org.apache.sling.resourceresolver.impl.helper.URI.encode(URI.java:1776)
> at org.apache.sling.resourceresolver.impl.helper.URI.setPath(URI.java:2938)
> at org.apache.sling.resourceresolver.impl.helper.URI.parseUriReference(URI.java:2118)
> ....{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)