[GitHub] [incubator-superset] suddjian removed a comment on issue #8655: [SIP-30] Remove Tabs in SQL Lab

[GitBox <gi...@apache.org>]

suddjian removed a comment on issue #8655: [SIP-30] Remove Tabs in SQL Lab
URL: https://github.com/apache/incubator-superset/issues/8655#issuecomment-563458825
 
 
   I've been thinking about this and discussing with colleagues, and there's an alternative approach that I think would be better. The idea is to implement the SQL Lab design as a new page, perhaps living at `/sqllab/new`.
   
   We can leave the existing SQL Lab page unchanged during development. Once the new SQL Lab is complete, we'll deprecate the existing page. The old Lab will still be available, tabs and all, but with a banner message notifying users that they should start using the new version instead.
   
   The migration process would be smoother: Users would have a new db field indicating which version of SQL Lab they are using. Users created after this change will see the new version at `/sqllab`. Existing users will still see the original version, with a banner linking to `/sqllab/new`. On the new page, there is a button saying "Make this my default SQL Lab". Once they click that, their user record is updated to reference the new sqllab version. Henceforth when they visit `/sqllab` they receive the new version.
   
   As far as I can tell, these pages should be able to operate independently of each other during the transition, while using the same backend API. Code from the original SQL Lab could be pulled into the new SQL Lab where appropriate, instead of trying to retrofit different functionality into the original page without breaking changes.
   
   Questions:
   - Do folks agree with this plan?
   - Should this SIP be replaced by a new SIP?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org