You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/08/10 03:29:15 UTC
[GitHub] [james-project] Arsnael commented on a diff in pull request #1108: James 3797 Moving all source code related to SpamAssassin to module third-party/spamassassin
Arsnael commented on code in PR #1108:
URL: https://github.com/apache/james-project/pull/1108#discussion_r941971983
##########
third-party/spamassassin/pom.xml:
##########
@@ -84,6 +88,17 @@
<artifactId>james-server-data-memory</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>${james.groupId}</groupId>
+ <artifactId>james-server-guice-common</artifactId>
+ <type>test-jar</type>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>${james.groupId}</groupId>
+ <artifactId>james-server-guice-configuration</artifactId>
+ <version>${james.baseVersion}</version>
Review Comment:
Is this really necessary? Logically you should not have to redeclare versions here? Idem for other concerned deps in this pom
##########
third-party/spamassassin/pom.xml:
##########
@@ -30,6 +30,10 @@
<name>Apache James :: Third Party :: SpamAssassin</name>
<description>SpamAssassin Java client and testing utilities</description>
+ <properties>
+ <james.baseVersion>${project.version}</james.baseVersion>
Review Comment:
What for? You already have `project.version` available
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org