You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/03/07 21:12:29 UTC
Review Request: Fixed cgroups isolation module to close the lock file on
finalize and cleaned up cgroups tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9806/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Description
-------
See summary.
Diffs
-----
src/linux/cgroups.cpp edce52475eb58f2aa8f1c99bcaf3cb269167fc1e
src/slave/cgroups_isolation_module.cpp c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7
src/tests/cgroups_tests.cpp ed419eb174a095786fb6de9e181d42587e5b40e2
src/tests/utils.hpp 0d4edad4787f92f86b1486b6b510f46a62d7d541
Diff: https://reviews.apache.org/r/9806/diff/
Testing
-------
./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose
Thanks,
Vinod Kone
Re: Review Request: Fixed cgroups isolation module to close the lock file on
finalize and cleaned up cgroups tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9806/
-----------------------------------------------------------
(Updated March 8, 2013, 7:45 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
Aah. I need coffee. Wrong review comment again :/
Description (updated)
-------
See summary.
Diffs
-----
src/linux/cgroups.cpp edce52475eb58f2aa8f1c99bcaf3cb269167fc1e
src/slave/cgroups_isolation_module.cpp c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7
src/tests/cgroups_tests.cpp ed419eb174a095786fb6de9e181d42587e5b40e2
src/tests/utils.hpp 0d4edad4787f92f86b1486b6b510f46a62d7d541
Diff: https://reviews.apache.org/r/9806/diff/
Testing
-------
./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose
Thanks,
Vinod Kone
Re: Review Request: Fixed cgroups isolation module to close the lock file on
finalize and cleaned up cgroups tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9806/
-----------------------------------------------------------
(Updated March 8, 2013, 7:44 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
Changed some CHECK_SOMEs to EXITs and incorporated BenM's changes from https://reviews.apache.org/r/9790/
Description
-------
See summary..
Diffs (updated)
-----
src/linux/cgroups.cpp edce52475eb58f2aa8f1c99bcaf3cb269167fc1e
src/slave/cgroups_isolation_module.cpp c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7
src/tests/cgroups_tests.cpp ed419eb174a095786fb6de9e181d42587e5b40e2
src/tests/utils.hpp 0d4edad4787f92f86b1486b6b510f46a62d7d541
Diff: https://reviews.apache.org/r/9806/diff/
Testing
-------
./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose
Thanks,
Vinod Kone
Re: Review Request: Fixed cgroups isolation module to close the lock file on
finalize and cleaned up cgroups tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9806/
-----------------------------------------------------------
(Updated March 8, 2013, 7:23 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
Ignore my comment, it was supposed to be for https://reviews.apache.org/r/9814/
Description (updated)
-------
See summary..
Diffs
-----
src/linux/cgroups.cpp edce52475eb58f2aa8f1c99bcaf3cb269167fc1e
src/slave/cgroups_isolation_module.cpp c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7
src/tests/cgroups_tests.cpp ed419eb174a095786fb6de9e181d42587e5b40e2
src/tests/utils.hpp 0d4edad4787f92f86b1486b6b510f46a62d7d541
Diff: https://reviews.apache.org/r/9806/diff/
Testing
-------
./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose
Thanks,
Vinod Kone
Re: Review Request: Fixed cgroups isolation module to close the lock file on
finalize and cleaned up cgroups tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9806/
-----------------------------------------------------------
(Updated March 8, 2013, 7:20 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
Renamed variable names per BenH's review.
Description
-------
See summary.
Diffs (updated)
-----
src/linux/cgroups.cpp edce52475eb58f2aa8f1c99bcaf3cb269167fc1e
src/slave/cgroups_isolation_module.cpp c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7
src/tests/cgroups_tests.cpp ed419eb174a095786fb6de9e181d42587e5b40e2
src/tests/utils.hpp 0d4edad4787f92f86b1486b6b510f46a62d7d541
Diff: https://reviews.apache.org/r/9806/diff/
Testing
-------
./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose
Thanks,
Vinod Kone
Re: Review Request: Fixed cgroups isolation module to close the lock file on
finalize and cleaned up cgroups tests.
Posted by Vinod Kone <vi...@gmail.com>.
> On March 8, 2013, 6:26 a.m., Benjamin Hindman wrote:
> > src/tests/cgroups_tests.cpp, line 126
> > <https://reviews.apache.org/r/9806/diff/3/?file=268318#file268318line126>
> >
> > Why can these be killed? I'd give a ship it but this seems concerning.
discussed offline. these are the correct semantics.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9806/#review17578
-----------------------------------------------------------
On March 8, 2013, 2:40 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9806/
> -----------------------------------------------------------
>
> (Updated March 8, 2013, 2:40 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp edce52475eb58f2aa8f1c99bcaf3cb269167fc1e
> src/slave/cgroups_isolation_module.cpp c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7
> src/tests/cgroups_tests.cpp ed419eb174a095786fb6de9e181d42587e5b40e2
> src/tests/utils.hpp 0d4edad4787f92f86b1486b6b510f46a62d7d541
>
> Diff: https://reviews.apache.org/r/9806/diff/
>
>
> Testing
> -------
>
> ./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed cgroups isolation module to close the lock file on
finalize and cleaned up cgroups tests.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On March 8, 2013, 6:26 a.m., Benjamin Hindman wrote:
> > src/slave/cgroups_isolation_module.cpp, lines 442-443
> > <https://reviews.apache.org/r/9806/diff/1/?file=268115#file268115line442>
> >
> > After David did all that work? ;)
I didn't actually mean to open an issue on this.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9806/#review17578
-----------------------------------------------------------
On March 8, 2013, 2:40 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9806/
> -----------------------------------------------------------
>
> (Updated March 8, 2013, 2:40 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp edce52475eb58f2aa8f1c99bcaf3cb269167fc1e
> src/slave/cgroups_isolation_module.cpp c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7
> src/tests/cgroups_tests.cpp ed419eb174a095786fb6de9e181d42587e5b40e2
> src/tests/utils.hpp 0d4edad4787f92f86b1486b6b510f46a62d7d541
>
> Diff: https://reviews.apache.org/r/9806/diff/
>
>
> Testing
> -------
>
> ./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed cgroups isolation module to close the lock file on
finalize and cleaned up cgroups tests.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9806/#review17578
-----------------------------------------------------------
src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/9806/#comment37272>
After David did all that work? ;)
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/9806/#comment37344>
Why can these be killed? I'd give a ship it but this seems concerning.
- Benjamin Hindman
On March 8, 2013, 2:40 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9806/
> -----------------------------------------------------------
>
> (Updated March 8, 2013, 2:40 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp edce52475eb58f2aa8f1c99bcaf3cb269167fc1e
> src/slave/cgroups_isolation_module.cpp c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7
> src/tests/cgroups_tests.cpp ed419eb174a095786fb6de9e181d42587e5b40e2
> src/tests/utils.hpp 0d4edad4787f92f86b1486b6b510f46a62d7d541
>
> Diff: https://reviews.apache.org/r/9806/diff/
>
>
> Testing
> -------
>
> ./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed cgroups isolation module to close the lock file on
finalize and cleaned up cgroups tests.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9806/#review17601
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On March 8, 2013, 2:40 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9806/
> -----------------------------------------------------------
>
> (Updated March 8, 2013, 2:40 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp edce52475eb58f2aa8f1c99bcaf3cb269167fc1e
> src/slave/cgroups_isolation_module.cpp c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7
> src/tests/cgroups_tests.cpp ed419eb174a095786fb6de9e181d42587e5b40e2
> src/tests/utils.hpp 0d4edad4787f92f86b1486b6b510f46a62d7d541
>
> Diff: https://reviews.apache.org/r/9806/diff/
>
>
> Testing
> -------
>
> ./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed cgroups isolation module to close the lock file on
finalize and cleaned up cgroups tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9806/
-----------------------------------------------------------
(Updated March 8, 2013, 2:40 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased off trunk.
Description
-------
See summary.
Diffs (updated)
-----
src/linux/cgroups.cpp edce52475eb58f2aa8f1c99bcaf3cb269167fc1e
src/slave/cgroups_isolation_module.cpp c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7
src/tests/cgroups_tests.cpp ed419eb174a095786fb6de9e181d42587e5b40e2
src/tests/utils.hpp 0d4edad4787f92f86b1486b6b510f46a62d7d541
Diff: https://reviews.apache.org/r/9806/diff/
Testing
-------
./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose
Thanks,
Vinod Kone
Re: Review Request: Fixed cgroups isolation module to close the lock file on
finalize and cleaned up cgroups tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9806/
-----------------------------------------------------------
(Updated March 8, 2013, 1:19 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's.
Description
-------
See summary.
Diffs (updated)
-----
src/linux/cgroups.cpp edce52475eb58f2aa8f1c99bcaf3cb269167fc1e
src/slave/cgroups_isolation_module.cpp c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7
src/tests/cgroups_tests.cpp ed419eb174a095786fb6de9e181d42587e5b40e2
src/tests/environment.cpp bda72ae0310e74015f3fbde50fecbf6515276e81
src/tests/utils.hpp 0d4edad4787f92f86b1486b6b510f46a62d7d541
Diff: https://reviews.apache.org/r/9806/diff/
Testing
-------
./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose
Thanks,
Vinod Kone
Re: Review Request: Fixed cgroups isolation module to close the lock file on
finalize and cleaned up cgroups tests.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9806/#review17570
-----------------------------------------------------------
Ship it!
src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/9806/#comment37250>
"Failed to ..."
src/tests/utils.hpp
<https://reviews.apache.org/r/9806/#comment37251>
s/to be//
- Ben Mahler
On March 7, 2013, 8:12 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9806/
> -----------------------------------------------------------
>
> (Updated March 7, 2013, 8:12 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp edce52475eb58f2aa8f1c99bcaf3cb269167fc1e
> src/slave/cgroups_isolation_module.cpp c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7
> src/tests/cgroups_tests.cpp ed419eb174a095786fb6de9e181d42587e5b40e2
> src/tests/utils.hpp 0d4edad4787f92f86b1486b6b510f46a62d7d541
>
> Diff: https://reviews.apache.org/r/9806/diff/
>
>
> Testing
> -------
>
> ./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose
>
>
> Thanks,
>
> Vinod Kone
>
>