You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Arun C Murthy (JIRA)" <ji...@apache.org> on 2007/11/17 17:03:43 UTC

[jira] Created: (HADOOP-2221) Configuration.toString is broken

Configuration.toString is broken
--------------------------------

                 Key: HADOOP-2221
                 URL: https://issues.apache.org/jira/browse/HADOOP-2221
             Project: Hadoop
          Issue Type: Bug
          Components: conf
    Affects Versions: 0.15.0
            Reporter: Arun C Murthy
            Assignee: Arun C Murthy
             Fix For: 0.15.1


{{Configuration.toString}} doesn't string-ify the {{Configuration.resources}} field which was added in HADOOP-785.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2221) Configuration.toString is broken

Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nigel Daley updated HADOOP-2221:
--------------------------------

    Fix Version/s:     (was: 0.15.1)
                   0.16.0

Not a blocker for 0.15.1

> Configuration.toString is broken
> --------------------------------
>
>                 Key: HADOOP-2221
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2221
>             Project: Hadoop
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.15.0
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2221_1_2007117.patch
>
>
> {{Configuration.toString}} doesn't string-ify the {{Configuration.resources}} field which was added in HADOOP-785.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2221) Configuration.toString is broken

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543703 ] 

Doug Cutting commented on HADOOP-2221:
--------------------------------------

Aren't both defaultResources and finalResources deprecated?  Eventually, all that we should print is 'resources'.  Perhaps it's time to sweep out some deprecated code rather than to embrace it.

> Configuration.toString is broken
> --------------------------------
>
>                 Key: HADOOP-2221
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2221
>             Project: Hadoop
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.15.0
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>             Fix For: 0.15.1
>
>         Attachments: HADOOP-2221_1_2007117.patch
>
>
> {{Configuration.toString}} doesn't string-ify the {{Configuration.resources}} field which was added in HADOOP-785.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2221) Configuration.toString is broken

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-2221:
----------------------------------

    Fix Version/s:     (was: 0.16.0)
                   0.17.0

Moving this to 0.17.0.

> Configuration.toString is broken
> --------------------------------
>
>                 Key: HADOOP-2221
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2221
>             Project: Hadoop
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.15.0
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>             Fix For: 0.17.0
>
>         Attachments: HADOOP-2221_1_2007117.patch
>
>
> {{Configuration.toString}} doesn't string-ify the {{Configuration.resources}} field which was added in HADOOP-785.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-2221) Configuration.toString is broken

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543303 ] 

Hadoop QA commented on HADOOP-2221:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12369725/HADOOP-2221_1_2007117.patch
against trunk revision r595563.

    @author +1.  The patch does not contain any @author tags.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new compiler warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

    contrib tests +1.  The patch passed contrib unit tests.

Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1115/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1115/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1115/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1115/console

This message is automatically generated.

> Configuration.toString is broken
> --------------------------------
>
>                 Key: HADOOP-2221
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2221
>             Project: Hadoop
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.15.0
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>             Fix For: 0.15.1
>
>         Attachments: HADOOP-2221_1_2007117.patch
>
>
> {{Configuration.toString}} doesn't string-ify the {{Configuration.resources}} field which was added in HADOOP-785.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2221) Configuration.toString is broken

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-2221:
----------------------------------

    Attachment: HADOOP-2221_1_2007117.patch

Here is a patch which fixes {{Configuration.toString}} and also supplies a test case.

> Configuration.toString is broken
> --------------------------------
>
>                 Key: HADOOP-2221
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2221
>             Project: Hadoop
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.15.0
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>             Fix For: 0.15.1
>
>         Attachments: HADOOP-2221_1_2007117.patch
>
>
> {{Configuration.toString}} doesn't string-ify the {{Configuration.resources}} field which was added in HADOOP-785.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2221) Configuration.toString is broken

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-2221:
----------------------------------

    Status: Patch Available  (was: Open)

> Configuration.toString is broken
> --------------------------------
>
>                 Key: HADOOP-2221
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2221
>             Project: Hadoop
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.15.0
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>             Fix For: 0.15.1
>
>         Attachments: HADOOP-2221_1_2007117.patch
>
>
> {{Configuration.toString}} doesn't string-ify the {{Configuration.resources}} field which was added in HADOOP-785.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-2221) Configuration.toString is broken

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated HADOOP-2221:
----------------------------------

    Status: Open  (was: Patch Available)

bq. Aren't both defaultResources and finalResources deprecated? Eventually, all that we should print is 'resources'. Perhaps it's time to sweep out some deprecated code rather than to embrace it.

I agree, though I had to keep them in for 0.15.1 (that was the original target-release I intended). 

Since folks feel this isn't critical enough to make it 0.15.1, I'll rework it for 0.16.0 and incorporate your suggestion.

> Configuration.toString is broken
> --------------------------------
>
>                 Key: HADOOP-2221
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2221
>             Project: Hadoop
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.15.0
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>             Fix For: 0.16.0
>
>         Attachments: HADOOP-2221_1_2007117.patch
>
>
> {{Configuration.toString}} doesn't string-ify the {{Configuration.resources}} field which was added in HADOOP-785.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.