[jira] [Commented] (PHOENIX-3175) Unnecessary UGI proxy user impersonation check

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416499#comment-15416499 ] 

Hadoop QA commented on PHOENIX-3175:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12823161/PHOENIX-3175.001.patch
  against master branch at commit ba82b1cb5a14c2cf109deb8a862389142d92f541.
  ATTACHMENT ID: 12823161

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 34 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/511//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/511//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/511//console

This message is automatically generated.

> Unnecessary UGI proxy user impersonation check
> ----------------------------------------------
>
>                 Key: PHOENIX-3175
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3175
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 4.9.0, 4.8.1
>
>         Attachments: PHOENIX-3175.001.patch
>
>
> While looking at some issues reported by [~jpplayer], we found that some of the default Hadoop proxyuser configuration properties in core-site.xml weren't working as intended.
> [~devaraj]'s keen eye noticed that PQS was doing an unnecessary UGI ProxyUser impersonation check.
> We can rely on the SPNEGO authentication as the barrier to use PQS, but then defer to the impersonation check that HBase is already doing as to which PQS instances are allowed to talk to HBase (defined by core-site.xml).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)