You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/11 19:43:24 UTC
[GitHub] flink pull request #3878: [FLINK-6561] Disable glob test on Windows
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3878
[FLINK-6561] Disable glob test on Windows
This PR disables a test case in the `GlobFilePathFilterTest`. The test verified that a file name containing asterisks `(*)` was properly filtered out; this however can't succeed on Windows since asterisks aren't allowed in file names in the first place. The creation of a nio path for such a file name throws an exception.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6561_glog_test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3878.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3878
----
commit f75edf840a1fb8633543518449f9373e40598001
Author: zentol <ch...@apache.org>
Date: 2017-05-11T19:24:02Z
[FLINK-6561] Disable glob test on Windows
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3878: [FLINK-6561] Disable glob test on Windows
Posted by zentol <gi...@git.apache.org>.
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/3878
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3878: [FLINK-6561] Disable glob test on Windows
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3878
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3878: [FLINK-6561] Disable glob test on Windows
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3878
Looks good, +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---