You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/01/11 09:34:29 UTC
[GitHub] [incubator-doris] ccoffline opened a new pull request #5216: [Feature] add broadcast_mem_limit (#5212)
ccoffline opened a new pull request #5216:
URL: https://github.com/apache/incubator-doris/pull/5216
## Proposed changes
as #5212
## Types of changes
- [] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [x] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
- [x] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] If this change need a document change, I have updated the document
- [x] Any dependent changes have been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] ccoffline commented on pull request #5216: [Feature] add broadcast_mem_limit (#5212)
Posted by GitBox <gi...@apache.org>.
ccoffline commented on pull request #5216:
URL: https://github.com/apache/incubator-doris/pull/5216#issuecomment-800142156
> Hi @ccoffline , we are working on a more accurate memory estimate model.
> And I think that will be better than setting a session variable.
May I have a view on this, maybe an issue, a doc or something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #5216: [Feature] add broadcast_mem_limit (#5212)
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on pull request #5216:
URL: https://github.com/apache/incubator-doris/pull/5216#issuecomment-805538678
> > Hi @ccoffline , we are working on a more accurate memory estimate model.
> > And I think that will be better than setting a session variable.
>
> May I have a view on this, maybe an issue, a doc or something?
I will add the PR and doc later.
Mainly based on our existing execution architecture, the method of evaluating the consumption of broadcast and shuffle has been modified.
So it will be much more accurate than before, so as to avoid the problem of wrong planning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #5216: [Feature] add broadcast_mem_limit (#5212)
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #5216:
URL: https://github.com/apache/incubator-doris/pull/5216#issuecomment-798856224
Hi @ccoffline , we are working on a more accurate memory estimate model.
And I think that will be better than setting a session variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org