You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2017/05/14 16:28:33 UTC

commons-pool git commit: Redo Javadoc fix (props Gary)

Repository: commons-pool
Updated Branches:
  refs/heads/master 2d42cec48 -> fc68e1ba7


Redo Javadoc fix (props Gary)

Project: http://git-wip-us.apache.org/repos/asf/commons-pool/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-pool/commit/fc68e1ba
Tree: http://git-wip-us.apache.org/repos/asf/commons-pool/tree/fc68e1ba
Diff: http://git-wip-us.apache.org/repos/asf/commons-pool/diff/fc68e1ba

Branch: refs/heads/master
Commit: fc68e1ba783b49df82e27fc88f4cb8819aa0b0c0
Parents: 2d42cec
Author: Sebb <se...@apache.org>
Authored: Sun May 14 17:28:30 2017 +0100
Committer: Sebb <se...@apache.org>
Committed: Sun May 14 17:28:30 2017 +0100

----------------------------------------------------------------------
 .../org/apache/commons/pool2/impl/GenericKeyedObjectPool.java    | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-pool/blob/fc68e1ba/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java b/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
index c4bf1ba..59ba113 100644
--- a/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
+++ b/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
@@ -52,6 +52,10 @@ import org.apache.commons.pool2.SwallowedExceptionListener;
  * provided to one of these methods, a sub-new pool is created under the given
  * key to be managed by the containing <code>GenericKeyedObjectPool.</code>
  * <p>
+ * Note that the current implementation uses a ConcurrentHashMap which uses
+ * equals() to compare keys.
+ * This means that distinct instance keys must be distinguishable using equals.
+ * <p>
  * Optionally, one may configure the pool to examine and possibly evict objects
  * as they sit idle in the pool and to ensure that a minimum number of idle
  * objects is maintained for each key. This is performed by an "idle object