You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "reschke (via GitHub)" <gi...@apache.org> on 2024/06/12 13:19:24 UTC

[PR] OAK-10803: use SystemPropertySupplier and make property name more specific [jackrabbit-oak]

reschke opened a new pull request, #1521:
URL: https://github.com/apache/jackrabbit-oak/pull/1521

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] OAK-10803: use SystemPropertySupplier and make property name more specific [jackrabbit-oak]

Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke closed pull request #1521: OAK-10803: use SystemPropertySupplier and make property name more specific
URL: https://github.com/apache/jackrabbit-oak/pull/1521


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] OAK-10803: use SystemPropertySupplier and make property name more specific [jackrabbit-oak]

Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on code in PR #1521:
URL: https://github.com/apache/jackrabbit-oak/pull/1521#discussion_r1636584715


##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##########
@@ -64,7 +65,8 @@ final class DocumentPropertyState implements PropertyState {
     private final byte[] compressedValue;
     private final Compression compression;
 
-    private static final int DEFAULT_COMPRESSION_THRESHOLD = Integer.getInteger("oak.mongo.compressionThreshold", -1);
+    private static final int DEFAULT_COMPRESSION_THRESHOLD = SystemPropertySupplier
+            .create("oak.documentMk.stringCompressionThreshold ", -1).loggingTo(LOG).get();

Review Comment:
   ```suggestion
               .create("oak.documentMK.stringCompressionThreshold ", -1).loggingTo(LOG).get();
   ```
   
   oups, my bad - looks like we use `MK` rather than `Mk` ...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] OAK-10803: use SystemPropertySupplier and make property name more specific [jackrabbit-oak]

Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on code in PR #1521:
URL: https://github.com/apache/jackrabbit-oak/pull/1521#discussion_r1636560400


##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##########
@@ -64,7 +65,9 @@ final class DocumentPropertyState implements PropertyState {
     private final byte[] compressedValue;
     private final Compression compression;
 
-    private static final int DEFAULT_COMPRESSION_THRESHOLD = Integer.getInteger("oak.mongo.compressionThreshold", -1);
+    private static final int DEFAULT_COMPRESSION_THRESHOLD = SystemPropertySupplier
+            .create("org.apache.jackrabbit.oak.plugins.document.DocumentPropertyState.stringCompressionThreshold", -1)

Review Comment:
   It seems we were able to come up with different naming conventions for system properties in oak-store-document even:
   * MemoryNodeStore uses `memoryds.`
   * rdb uses `full.qualified.name`
   * org.apache.jackrabbit.oak.plugins.document in general uses `oak.documentMk.`
   
   Perhaps as this is in the main document package, should we use `oak.documentMk.stringCompressionThreshold` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] OAK-10803: use SystemPropertySupplier and make property name more specific [jackrabbit-oak]

Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on code in PR #1521:
URL: https://github.com/apache/jackrabbit-oak/pull/1521#discussion_r1636562188


##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java:
##########
@@ -64,7 +65,9 @@ final class DocumentPropertyState implements PropertyState {
     private final byte[] compressedValue;
     private final Compression compression;
 
-    private static final int DEFAULT_COMPRESSION_THRESHOLD = Integer.getInteger("oak.mongo.compressionThreshold", -1);
+    private static final int DEFAULT_COMPRESSION_THRESHOLD = SystemPropertySupplier
+            .create("org.apache.jackrabbit.oak.plugins.document.DocumentPropertyState.stringCompressionThreshold", -1)

Review Comment:
   Sounds good to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org