(iceberg-go) branch main updated: fix(catalog/sql): handle error for metadata location while dropping view (#648)

[ze...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

zeroshade pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-go.git


The following commit(s) were added to refs/heads/main by this push:
     new f886a245 fix(catalog/sql): handle error for metadata location while dropping view (#648)
f886a245 is described below

commit f886a245b43df648b9b42148ed0d77c04f1d34c8
Author: ferhat elmas <el...@gmail.com>
AuthorDate: Thu Dec 11 20:52:32 2025 +0100

    fix(catalog/sql): handle error for metadata location while dropping view (#648)
    
    Signed-off-by: ferhat elmas <el...@gmail.com>
---
 catalog/sql/sql.go      |  2 +-
 catalog/sql/sql_test.go | 56 ++++++++++++++++++++++++++++++++++++++-----------
 2 files changed, 45 insertions(+), 13 deletions(-)

diff --git a/catalog/sql/sql.go b/catalog/sql/sql.go
index 57003d50..1e4a8ecd 100644
--- a/catalog/sql/sql.go
+++ b/catalog/sql/sql.go
@@ -983,7 +983,7 @@ func (c *Catalog) DropView(ctx context.Context, identifier table.Identifier) err
 	if metadataLocation != "" {
 		fs, err := io.LoadFS(ctx, c.props, metadataLocation)
 		if err != nil {
-			return nil
+			return err
 		}
 
 		_ = fs.Remove(metadataLocation)
diff --git a/catalog/sql/sql_test.go b/catalog/sql/sql_test.go
index 2e0a0a59..6ac0fdb8 100644
--- a/catalog/sql/sql_test.go
+++ b/catalog/sql/sql_test.go
@@ -278,12 +278,12 @@ func (s *SqliteCatalogTestSuite) TestCreationOneTableExists() {
 	s.confirmNoTables(sqldb)
 
 	_, err := sqldb.Exec(`CREATE TABLE "iceberg_tables" (
-		"catalog_name" VARCHAR NOT NULL, 
-		"table_namespace" VARCHAR NOT NULL, 
+		"catalog_name" VARCHAR NOT NULL,
+		"table_namespace" VARCHAR NOT NULL,
 		"table_name" VARCHAR NOT NULL,
 		"iceberg_type" VARCHAR NOT NULL DEFAULT 'TABLE',
-		"metadata_location" VARCHAR, 
-		"previous_metadata_location" VARCHAR, 
+		"metadata_location" VARCHAR,
+		"previous_metadata_location" VARCHAR,
 		PRIMARY KEY ("catalog_name", "table_namespace", "table_name"))`)
 	s.Require().NoError(err)
 
@@ -297,20 +297,20 @@ func (s *SqliteCatalogTestSuite) TestCreationAllTablesExist() {
 	s.confirmNoTables(sqldb)
 
 	_, err := sqldb.Exec(`CREATE TABLE "iceberg_tables" (
-		"catalog_name" VARCHAR NOT NULL, 
-		"table_namespace" VARCHAR NOT NULL, 
+		"catalog_name" VARCHAR NOT NULL,
+		"table_namespace" VARCHAR NOT NULL,
 		"table_name" VARCHAR NOT NULL,
 		"iceberg_type" VARCHAR,
-		"metadata_location" VARCHAR, 
-		"previous_metadata_location" VARCHAR, 
+		"metadata_location" VARCHAR,
+		"previous_metadata_location" VARCHAR,
 		PRIMARY KEY ("catalog_name", "table_namespace", "table_name"))`)
 	s.Require().NoError(err)
 
 	_, err = sqldb.Exec(`CREATE TABLE "iceberg_namespace_properties" (
-		"catalog_name" VARCHAR NOT NULL, 
-		"namespace" VARCHAR NOT NULL, 
-		"property_key" VARCHAR NOT NULL, 
-		"property_value" VARCHAR, 
+		"catalog_name" VARCHAR NOT NULL,
+		"namespace" VARCHAR NOT NULL,
+		"property_key" VARCHAR NOT NULL,
+		"property_value" VARCHAR,
 		PRIMARY KEY ("catalog_name", "namespace", "property_key"))`)
 	s.Require().NoError(err)
 
@@ -1097,6 +1097,38 @@ func (s *SqliteCatalogTestSuite) TestDropView() {
 	s.ErrorIs(err, catalog.ErrNoSuchView)
 }
 
+func (s *SqliteCatalogTestSuite) TestDropViewWithInvalidMetadataLocation() {
+	db := s.getCatalogSqlite()
+	s.Require().NoError(db.CreateSQLTables(context.Background()))
+
+	nsName := databaseName()
+	viewName := tableName()
+	s.Require().NoError(db.CreateNamespace(context.Background(), []string{nsName}, nil))
+
+	viewSQL := "SELECT * FROM test_table"
+	schema := iceberg.NewSchema(1, iceberg.NestedField{
+		ID: 1, Name: "id", Type: iceberg.PrimitiveTypes.Int32, Required: true,
+	})
+	s.Require().NoError(db.CreateView(context.Background(), []string{nsName, viewName}, schema, viewSQL, nil))
+
+	// Manually update the metadata location to a URL with an unsupported scheme
+	// This will cause io.LoadFS to fail with "IO for file '...' not implemented"
+	sqldb := s.getDB()
+	defer sqldb.Close()
+
+	_, err := sqldb.Exec(
+		"UPDATE iceberg_tables SET metadata_location = ? WHERE table_namespace = ? AND table_name = ?",
+		"unsupported-scheme://bucket/metadata.json",
+		nsName,
+		viewName,
+	)
+	s.Require().NoError(err)
+
+	// DropView should return an error when io.LoadFS fails
+	err = db.DropView(context.Background(), []string{nsName, viewName})
+	s.Error(err, "DropView should return an error when LoadFS fails for invalid metadata location")
+}
+
 func (s *SqliteCatalogTestSuite) TestCheckViewExists() {
 	db := s.getCatalogSqlite()
 	s.Require().NoError(db.CreateSQLTables(context.Background()))