[GitHub] [camel-k] lburgazzoli commented on a change in pull request #720: Allow to provide custom settings.xml

[GitBox <gi...@apache.org>]

lburgazzoli commented on a change in pull request #720:  Allow to provide custom settings.xml
URL: https://github.com/apache/camel-k/pull/720#discussion_r289946757
 
 

 ##########
 File path: pkg/cmd/install.go
 ##########
 @@ -210,6 +200,68 @@ func (o *installCmdOptions) install(_ *cobra.Command, _ []string) error {
 			platform.Spec.Build.Timeout.Duration = d
 		}
 
+		if len(o.repositories) > 0 {
+			o.mavenSettings = fmt.Sprintf("configmap:%s-maven-settings/settings.xml", platform.Name)
+
+			settings := maven.NewSettings()
 
 Review comment:
   I think the problem is still the same, what if the user does not set it ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services