You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/08/26 19:35:07 UTC
[GitHub] [solr] Caa52 opened a new pull request #273: Solr 13209: Fix NullPointerException error resulting from parsing null query
Caa52 opened a new pull request #273:
URL: https://github.com/apache/solr/pull/273
https://issues.apache.org/jira/browse/SOLR-13209
# Description
A null pointer exception is raised when parsing a null query. It requires a better way to check for and handle cases where the query is null
# Solution
- Created new test testGroupingNPEmptyString to test the case of a null query
- Added additional check in addQueryCommand method to check and appropriately handle cases of null queries, instead of just assuming that queries are not null
# Tests
Created testGroupingNPEmptyString in the Grouping class to validate the changes made
# Checklist
Please review the following and check all that apply:
- [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [X] I have created a Jira issue and added the issue ID to my pull request title.
- [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [X] I have developed this patch against the `main` branch.
- [X] I have run `./gradlew check`.
- [X] I have added tests for my changes.
- [X] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #273: SOLR-13209: Fix NullPointerException error resulting from parsing null query
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #273:
URL: https://github.com/apache/solr/pull/273#issuecomment-907296256
Looks good, tests pass.
Can you please add an entry to `solr/CHANGES.txt` under Bug Fixes including how you would like to be credited? Something like "Fix NPE when no grouping query specified"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob closed pull request #273: SOLR-13209: Fix NullPointerException error resulting from parsing null query
Posted by GitBox <gi...@apache.org>.
madrob closed pull request #273:
URL: https://github.com/apache/solr/pull/273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob closed pull request #273: SOLR-13209: Fix NullPointerException error resulting from parsing null query
Posted by GitBox <gi...@apache.org>.
madrob closed pull request #273:
URL: https://github.com/apache/solr/pull/273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org