[jira] [Commented] (YARN-5366) Add support for toggling the removal of completed and failed docker containers

["Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-5366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905665#comment-15905665 ] 

Vinod Kumar Vavilapalli commented on YARN-5366:
-----------------------------------------------

[~shanekumpf@gmail.com], just started looking at the patch, but one early thought: Instead of a new config option {{allow-keep-container-on-exit}}, why not just use the existing administrative flag {{yarn.nodemanager.delete.debug-delay-sec}}? This config delays the deletion of files for regular containers, we can use the same thing to decide when to delete docker containers.

One thing's for sure, we shouldn't let end-user application control when the files / container meta should be deleted - if every user/app chooses to not delete, (a) admins have to write external scripts to delete them and (b) absent that, NMs may go out of space.

> Add support for toggling the removal of completed and failed docker containers
> ------------------------------------------------------------------------------
>
>                 Key: YARN-5366
>                 URL: https://issues.apache.org/jira/browse/YARN-5366
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>            Reporter: Shane Kumpf
>            Assignee: Shane Kumpf
>              Labels: oct16-medium
>         Attachments: YARN-5366.001.patch, YARN-5366.002.patch, YARN-5366.003.patch, YARN-5366.004.patch, YARN-5366.005.patch, YARN-5366.006.patch
>
>
> Currently, completed and failed docker containers are removed by container-executor. Add a job level environment variable to DockerLinuxContainerRuntime to allow the user to toggle whether they want the container deleted or not and remove the logic from container-executor.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org