You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/24 14:09:43 UTC
[GitHub] [airflow] potiuk opened a new pull request, #28578: Update black version automatically in pre-commit configuration
potiuk opened a new pull request, #28578:
URL: https://github.com/apache/airflow/pull/28578
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28578: Update black version automatically in pre-commit configuration
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28578:
URL: https://github.com/apache/airflow/pull/28578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28578: Update black version automatically in pre-commit configuration
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28578:
URL: https://github.com/apache/airflow/pull/28578#issuecomment-1364585868
Inception indeed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28578: Update black version automatically in pre-commit configuration
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28578:
URL: https://github.com/apache/airflow/pull/28578#issuecomment-1364543182
random failure. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #28578: Update black version automatically in pre-commit configuration
Posted by GitBox <gi...@apache.org>.
kaxil commented on PR #28578:
URL: https://github.com/apache/airflow/pull/28578#issuecomment-1364582670
Love it, pre-commit to handle pre-commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28578: Update black version automatically in pre-commit configuration
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28578:
URL: https://github.com/apache/airflow/pull/28578#issuecomment-1364539136
BTW. Rich is a different problem - it is >= limited to force an upgrade for everyone for a buggy version, but we do not want to specifically synchronize it to specific version.
There is a big difference - rich is just to "print" output to the user (and auto-update of rich is something that happens automatically with `pre-comit auto-update`. And we REALLY WANT to keep it syncrhonized in pre-commits because black reformats our generated code, so we want to make sure the reformatting is not conflicting with regular formatting applied by the pre-commit. If black changes the decision about formatting (happened in the past) this would mean that our pre-commits will be cancelling each-others formatting when a new file is generated (that's why also we want to fix black so that formatting is the same for users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28578: Update black version automatically in pre-commit configuration
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28578:
URL: https://github.com/apache/airflow/pull/28578#issuecomment-1364538317
> I think it's not just for black.. also rich and possibly others? I wonder if we can use aliasing the version number https://hackernoon.com/repeating-nodes-with-yaml-aliases-like-a-pro-5jn34yo
Feel free to do it for others too :). Should be easy to do follow-up in a similar way.
Yaml aliasing only work on nodes not on sub-strings inside the nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28578: Update black version automatically in pre-commit configuration
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28578:
URL: https://github.com/apache/airflow/pull/28578#issuecomment-1364539518
Here is more info why YAML anchors (I am not even sure if they are supported for pre-commits) would not work for string replacement: https://stackoverflow.com/questions/59721008/embedding-yaml-alias-within-yaml-string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org