You are viewing a plain text version of this content. The canonical link for it is here.
Posted to npanday-commits@incubator.apache.org by "Lars Corneliussen (JIRA)" <ji...@apache.org> on 2011/05/01 22:10:03 UTC

[jira] [Created] (NPANDAY-422) .NET-Plugins can not have custom dependencies

.NET-Plugins can not have custom dependencies
---------------------------------------------

                 Key: NPANDAY-422
                 URL: https://issues.apache.org/jira/browse/NPANDAY-422
             Project: NPanday
          Issue Type: Improvement
          Components: Maven Plugins
    Affects Versions: 1.3.1-incubating
            Reporter: Lars Corneliussen


For 1.3.1 the PAB was removed. Instead, before executing, stuff is moved to reactor's root 'target'-directory.

But dependencies are not copied along. Onyl NPanday.Plugin is manually copied.

{code:title=NetExecutableFactoryImpl.java/getNetExecutableFromRepository}
//TODO: Replace
String pluginArtifactPath = PathUtil.getPrivateApplicationBaseFileFor(
artifactContext.getArtifactsFor( "npanday.plugin", "NPanday.Plugin", null, null ).get( 0 ),
localRepository ).getAbsolutePath();
{code}

The place, where files are copied is also quite weird. Documentation and bethod name don't fit at all.

getPrivateApplicationBaseFileFor runs PathUtil.getDotNetArtifact(), which then copies the file.
{code:title=PathUtil.getDotNetArtifact(Artifact, String)}
/**
* Returns the path of the artifact within the user assembly cache.
*
* @param artifact        the artifact to find the path of. This value should not be null.
* @return the path of the artifact within the user assembly cache or null if either of the specified
*         parameters is null
*/
public static File getDotNetArtifact( Artifact artifact, String source )
{code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (NPANDAY-422) [regression introduced by 186] .NET-Plugins can not have custom dependencies

Posted by "Lars Corneliussen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NPANDAY-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Corneliussen resolved NPANDAY-422.
---------------------------------------

    Resolution: Fixed
    
> [regression introduced by 186] .NET-Plugins can not have custom dependencies
> ----------------------------------------------------------------------------
>
>                 Key: NPANDAY-422
>                 URL: https://issues.apache.org/jira/browse/NPANDAY-422
>             Project: NPanday
>          Issue Type: Improvement
>          Components: Maven Plugins
>    Affects Versions: 1.4-incubating
>            Reporter: Lars Corneliussen
>            Assignee: Lars Corneliussen
>             Fix For: 1.5.0-incubating
>
>
> For 1.3.1 the PAB was removed. Instead, before executing, stuff is moved to reactor's root 'target'-directory.
> But dependencies are not copied along. Onyl NPanday.Plugin is manually copied.
> {code:title=NetExecutableFactoryImpl.java/getNetExecutableFromRepository}
> //TODO: Replace
> String pluginArtifactPath = PathUtil.getPrivateApplicationBaseFileFor(
> artifactContext.getArtifactsFor( "npanday.plugin", "NPanday.Plugin", null, null ).get( 0 ),
> localRepository ).getAbsolutePath();
> {code}
> The place, where files are copied is also quite weird. Documentation and bethod name don't fit at all.
> getPrivateApplicationBaseFileFor runs PathUtil.getDotNetArtifact(), which then copies the file.
> {code:title=PathUtil.getDotNetArtifact(Artifact, String)}
> /**
> * Returns the path of the artifact within the user assembly cache.
> *
> * @param artifact        the artifact to find the path of. This value should not be null.
> * @return the path of the artifact within the user assembly cache or null if either of the specified
> *         parameters is null
> */
> public static File getDotNetArtifact( Artifact artifact, String source )
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (NPANDAY-422) [regression introduced by 186] .NET-Plugins can not have custom dependencies

Posted by "Brett Porter (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NPANDAY-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163336#comment-13163336 ] 

Brett Porter commented on NPANDAY-422:
--------------------------------------

addressed the second half (somewhat) in fix for NPANDAY-410. More work to do to clean up PathUtil, that can be done with the RDF removal.
                
> [regression introduced by 186] .NET-Plugins can not have custom dependencies
> ----------------------------------------------------------------------------
>
>                 Key: NPANDAY-422
>                 URL: https://issues.apache.org/jira/browse/NPANDAY-422
>             Project: NPanday
>          Issue Type: Improvement
>          Components: Maven Plugins
>    Affects Versions: 1.4-incubating
>            Reporter: Lars Corneliussen
>             Fix For: 1.4.1-incubating
>
>
> For 1.3.1 the PAB was removed. Instead, before executing, stuff is moved to reactor's root 'target'-directory.
> But dependencies are not copied along. Onyl NPanday.Plugin is manually copied.
> {code:title=NetExecutableFactoryImpl.java/getNetExecutableFromRepository}
> //TODO: Replace
> String pluginArtifactPath = PathUtil.getPrivateApplicationBaseFileFor(
> artifactContext.getArtifactsFor( "npanday.plugin", "NPanday.Plugin", null, null ).get( 0 ),
> localRepository ).getAbsolutePath();
> {code}
> The place, where files are copied is also quite weird. Documentation and bethod name don't fit at all.
> getPrivateApplicationBaseFileFor runs PathUtil.getDotNetArtifact(), which then copies the file.
> {code:title=PathUtil.getDotNetArtifact(Artifact, String)}
> /**
> * Returns the path of the artifact within the user assembly cache.
> *
> * @param artifact        the artifact to find the path of. This value should not be null.
> * @return the path of the artifact within the user assembly cache or null if either of the specified
> *         parameters is null
> */
> public static File getDotNetArtifact( Artifact artifact, String source )
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (NPANDAY-422) [regression introduced by 186] .NET-Plugins can not have custom dependencies

Posted by "Lars Corneliussen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NPANDAY-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Corneliussen reassigned NPANDAY-422:
-----------------------------------------

    Assignee: Lars Corneliussen
    
> [regression introduced by 186] .NET-Plugins can not have custom dependencies
> ----------------------------------------------------------------------------
>
>                 Key: NPANDAY-422
>                 URL: https://issues.apache.org/jira/browse/NPANDAY-422
>             Project: NPanday
>          Issue Type: Improvement
>          Components: Maven Plugins
>    Affects Versions: 1.4-incubating
>            Reporter: Lars Corneliussen
>            Assignee: Lars Corneliussen
>             Fix For: 1.5.0-incubating
>
>
> For 1.3.1 the PAB was removed. Instead, before executing, stuff is moved to reactor's root 'target'-directory.
> But dependencies are not copied along. Onyl NPanday.Plugin is manually copied.
> {code:title=NetExecutableFactoryImpl.java/getNetExecutableFromRepository}
> //TODO: Replace
> String pluginArtifactPath = PathUtil.getPrivateApplicationBaseFileFor(
> artifactContext.getArtifactsFor( "npanday.plugin", "NPanday.Plugin", null, null ).get( 0 ),
> localRepository ).getAbsolutePath();
> {code}
> The place, where files are copied is also quite weird. Documentation and bethod name don't fit at all.
> getPrivateApplicationBaseFileFor runs PathUtil.getDotNetArtifact(), which then copies the file.
> {code:title=PathUtil.getDotNetArtifact(Artifact, String)}
> /**
> * Returns the path of the artifact within the user assembly cache.
> *
> * @param artifact        the artifact to find the path of. This value should not be null.
> * @return the path of the artifact within the user assembly cache or null if either of the specified
> *         parameters is null
> */
> public static File getDotNetArtifact( Artifact artifact, String source )
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (NPANDAY-422) .NET-Plugins can not have custom dependencies

Posted by "Lars Corneliussen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NPANDAY-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027550#comment-13027550 ] 

Lars Corneliussen commented on NPANDAY-422:
-------------------------------------------

It should. but we should also release soon. Who has capacity to fix it?

> .NET-Plugins can not have custom dependencies
> ---------------------------------------------
>
>                 Key: NPANDAY-422
>                 URL: https://issues.apache.org/jira/browse/NPANDAY-422
>             Project: NPanday
>          Issue Type: Improvement
>          Components: Maven Plugins
>    Affects Versions: 1.3.1-incubating
>            Reporter: Lars Corneliussen
>
> For 1.3.1 the PAB was removed. Instead, before executing, stuff is moved to reactor's root 'target'-directory.
> But dependencies are not copied along. Onyl NPanday.Plugin is manually copied.
> {code:title=NetExecutableFactoryImpl.java/getNetExecutableFromRepository}
> //TODO: Replace
> String pluginArtifactPath = PathUtil.getPrivateApplicationBaseFileFor(
> artifactContext.getArtifactsFor( "npanday.plugin", "NPanday.Plugin", null, null ).get( 0 ),
> localRepository ).getAbsolutePath();
> {code}
> The place, where files are copied is also quite weird. Documentation and bethod name don't fit at all.
> getPrivateApplicationBaseFileFor runs PathUtil.getDotNetArtifact(), which then copies the file.
> {code:title=PathUtil.getDotNetArtifact(Artifact, String)}
> /**
> * Returns the path of the artifact within the user assembly cache.
> *
> * @param artifact        the artifact to find the path of. This value should not be null.
> * @return the path of the artifact within the user assembly cache or null if either of the specified
> *         parameters is null
> */
> public static File getDotNetArtifact( Artifact artifact, String source )
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (NPANDAY-422) [regression introduced by 186] .NET-Plugins can not have custom dependencies

Posted by "Lars Corneliussen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NPANDAY-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266431#comment-13266431 ] 

Lars Corneliussen commented on NPANDAY-422:
-------------------------------------------

Should be fixed with NPANDAY-231; we should try to remove NPanday.Plugin to see if it works.
                
> [regression introduced by 186] .NET-Plugins can not have custom dependencies
> ----------------------------------------------------------------------------
>
>                 Key: NPANDAY-422
>                 URL: https://issues.apache.org/jira/browse/NPANDAY-422
>             Project: NPanday
>          Issue Type: Improvement
>          Components: Maven Plugins
>    Affects Versions: 1.4-incubating
>            Reporter: Lars Corneliussen
>            Assignee: Lars Corneliussen
>             Fix For: 1.5.0-incubating
>
>
> For 1.3.1 the PAB was removed. Instead, before executing, stuff is moved to reactor's root 'target'-directory.
> But dependencies are not copied along. Onyl NPanday.Plugin is manually copied.
> {code:title=NetExecutableFactoryImpl.java/getNetExecutableFromRepository}
> //TODO: Replace
> String pluginArtifactPath = PathUtil.getPrivateApplicationBaseFileFor(
> artifactContext.getArtifactsFor( "npanday.plugin", "NPanday.Plugin", null, null ).get( 0 ),
> localRepository ).getAbsolutePath();
> {code}
> The place, where files are copied is also quite weird. Documentation and bethod name don't fit at all.
> getPrivateApplicationBaseFileFor runs PathUtil.getDotNetArtifact(), which then copies the file.
> {code:title=PathUtil.getDotNetArtifact(Artifact, String)}
> /**
> * Returns the path of the artifact within the user assembly cache.
> *
> * @param artifact        the artifact to find the path of. This value should not be null.
> * @return the path of the artifact within the user assembly cache or null if either of the specified
> *         parameters is null
> */
> public static File getDotNetArtifact( Artifact artifact, String source )
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (NPANDAY-422) .NET-Plugins can not have custom dependencies

Posted by "Brett Porter (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/NPANDAY-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027522#comment-13027522 ] 

Brett Porter commented on NPANDAY-422:
--------------------------------------

IIUC this is a regression we need to schedule for 1.3.1?

> .NET-Plugins can not have custom dependencies
> ---------------------------------------------
>
>                 Key: NPANDAY-422
>                 URL: https://issues.apache.org/jira/browse/NPANDAY-422
>             Project: NPanday
>          Issue Type: Improvement
>          Components: Maven Plugins
>    Affects Versions: 1.3.1-incubating
>            Reporter: Lars Corneliussen
>
> For 1.3.1 the PAB was removed. Instead, before executing, stuff is moved to reactor's root 'target'-directory.
> But dependencies are not copied along. Onyl NPanday.Plugin is manually copied.
> {code:title=NetExecutableFactoryImpl.java/getNetExecutableFromRepository}
> //TODO: Replace
> String pluginArtifactPath = PathUtil.getPrivateApplicationBaseFileFor(
> artifactContext.getArtifactsFor( "npanday.plugin", "NPanday.Plugin", null, null ).get( 0 ),
> localRepository ).getAbsolutePath();
> {code}
> The place, where files are copied is also quite weird. Documentation and bethod name don't fit at all.
> getPrivateApplicationBaseFileFor runs PathUtil.getDotNetArtifact(), which then copies the file.
> {code:title=PathUtil.getDotNetArtifact(Artifact, String)}
> /**
> * Returns the path of the artifact within the user assembly cache.
> *
> * @param artifact        the artifact to find the path of. This value should not be null.
> * @return the path of the artifact within the user assembly cache or null if either of the specified
> *         parameters is null
> */
> public static File getDotNetArtifact( Artifact artifact, String source )
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Work started] (NPANDAY-422) [regression introduced by 186] .NET-Plugins can not have custom dependencies

Posted by "Lars Corneliussen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NPANDAY-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on NPANDAY-422 started by Lars Corneliussen.

> [regression introduced by 186] .NET-Plugins can not have custom dependencies
> ----------------------------------------------------------------------------
>
>                 Key: NPANDAY-422
>                 URL: https://issues.apache.org/jira/browse/NPANDAY-422
>             Project: NPanday
>          Issue Type: Improvement
>          Components: Maven Plugins
>    Affects Versions: 1.4-incubating
>            Reporter: Lars Corneliussen
>            Assignee: Lars Corneliussen
>             Fix For: 1.5.0-incubating
>
>
> For 1.3.1 the PAB was removed. Instead, before executing, stuff is moved to reactor's root 'target'-directory.
> But dependencies are not copied along. Onyl NPanday.Plugin is manually copied.
> {code:title=NetExecutableFactoryImpl.java/getNetExecutableFromRepository}
> //TODO: Replace
> String pluginArtifactPath = PathUtil.getPrivateApplicationBaseFileFor(
> artifactContext.getArtifactsFor( "npanday.plugin", "NPanday.Plugin", null, null ).get( 0 ),
> localRepository ).getAbsolutePath();
> {code}
> The place, where files are copied is also quite weird. Documentation and bethod name don't fit at all.
> getPrivateApplicationBaseFileFor runs PathUtil.getDotNetArtifact(), which then copies the file.
> {code:title=PathUtil.getDotNetArtifact(Artifact, String)}
> /**
> * Returns the path of the artifact within the user assembly cache.
> *
> * @param artifact        the artifact to find the path of. This value should not be null.
> * @return the path of the artifact within the user assembly cache or null if either of the specified
> *         parameters is null
> */
> public static File getDotNetArtifact( Artifact artifact, String source )
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (NPANDAY-422) [regression introduced by 186] .NET-Plugins can not have custom dependencies

Posted by "Lars Corneliussen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NPANDAY-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Corneliussen updated NPANDAY-422:
--------------------------------------

    Fix Version/s: 1.3.2-incubating
          Summary: [regression introduced by 186] .NET-Plugins can not have custom dependencies  (was: .NET-Plugins can not have custom dependencies)

> [regression introduced by 186] .NET-Plugins can not have custom dependencies
> ----------------------------------------------------------------------------
>
>                 Key: NPANDAY-422
>                 URL: https://issues.apache.org/jira/browse/NPANDAY-422
>             Project: NPanday
>          Issue Type: Improvement
>          Components: Maven Plugins
>    Affects Versions: 1.3.1-incubating
>            Reporter: Lars Corneliussen
>             Fix For: 1.3.2-incubating
>
>
> For 1.3.1 the PAB was removed. Instead, before executing, stuff is moved to reactor's root 'target'-directory.
> But dependencies are not copied along. Onyl NPanday.Plugin is manually copied.
> {code:title=NetExecutableFactoryImpl.java/getNetExecutableFromRepository}
> //TODO: Replace
> String pluginArtifactPath = PathUtil.getPrivateApplicationBaseFileFor(
> artifactContext.getArtifactsFor( "npanday.plugin", "NPanday.Plugin", null, null ).get( 0 ),
> localRepository ).getAbsolutePath();
> {code}
> The place, where files are copied is also quite weird. Documentation and bethod name don't fit at all.
> getPrivateApplicationBaseFileFor runs PathUtil.getDotNetArtifact(), which then copies the file.
> {code:title=PathUtil.getDotNetArtifact(Artifact, String)}
> /**
> * Returns the path of the artifact within the user assembly cache.
> *
> * @param artifact        the artifact to find the path of. This value should not be null.
> * @return the path of the artifact within the user assembly cache or null if either of the specified
> *         parameters is null
> */
> public static File getDotNetArtifact( Artifact artifact, String source )
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira