You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/11/16 21:59:16 UTC

[GitHub] mistercrunch commented on issue #6360: [SIP-15] Transparent and Consistent Time Intervals

mistercrunch commented on issue #6360: [SIP-15] Transparent and Consistent Time Intervals
URL: https://github.com/apache/incubator-superset/issues/6360#issuecomment-439542259
 
 
   +1 on relative expressions showing what they evaluate too instantly in the control
   
   About the inclusive `<=` right bound, I also believe it should be exclusive. One way to do proper change management on this would be to:
   * offer the option to `<=` or `<` on the control itself
   * set the default to `<` for future/new charts
   * set value to `<=` for all existing charts
   
   That way:
   * backwards compatibility is maintained
   * option is available 
   * UI is clear about the behavior
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org