[GitHub] [kafka] chia7712 commented on a change in pull request #9790: Some parameters will be overwritten which was configured in consumer.config.

[GitBox <gi...@apache.org>]

chia7712 commented on a change in pull request #9790:
URL: https://github.com/apache/kafka/pull/9790#discussion_r549578153



##########
File path: core/src/test/scala/unit/kafka/tools/ConsumerPerformanceTest.scala
##########
@@ -96,6 +97,28 @@ class ConsumerPerformanceTest {
     assertEquals("test", config.topic)
     assertEquals(10, config.numMessages)
   }
+  
+  @Test
+  def testConfigWithRecognizedOptionOverride(): Unit = {
+    val propsFile = TestUtils.tempFile()
+    val propsStream = Files.newOutputStream(propsFile.toPath)
+    propsStream.write("group.id=test_group_id\n".getBytes())
+    propsStream.write("client.id=test_client_id".getBytes())
+    propsStream.close()

Review comment:
       Could you test ```--topic``` to make sure it is not overrided by command-line arguments.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org