[GitHub] pengzhao-intel commented on a change in pull request #13324: Fix/env disable mkldnn cache map

[GitBox <gi...@apache.org>]

pengzhao-intel commented on a change in pull request #13324: Fix/env disable mkldnn cache map
URL: https://github.com/apache/incubator-mxnet/pull/13324#discussion_r235635700
 
 

 ##########
 File path: docs/faq/env_var.md
 ##########
 @@ -195,6 +195,10 @@ When USE_PROFILER is enabled in Makefile or CMake, the following environments ca
   - Values: 0, 1 ```(default=1)```
   - Flag to enable or disable MKLDNN accelerator. On by default.
   - Only applies to mxnet that has been compiled with MKLDNN (```pip install mxnet-mkl``` or built from source with ```USE_MKLDNN=1```)
+  
+* MXNET_MKLDNN_CACHE_SIZE
+  - Values: Int ```(default=-1)```
+  - Flag to set MKLDNN cache size. Default is -1 which means cache size is unbounded. Should only be set if your model has variable input shapes, as cache size may grow unbounded. The number represents the number of items in the cache and is proportional to the number of layers that use MKLDNN and different input shape.
 
 
 Review comment:
   The name of this variable is a little confusion. Traditionally,  "SIZE" means real bytes in the CS, right?  In here, it represents the number of items.  How about "MXNET_MKLDNN_CACHE_NUM" or other proposals?
   I am not the native speaker of English, feel free to correct me :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services