Re: [PR] Encode all join conditions in a single expression field [arrow-datafusion]

["nseekhao (via GitHub)" <gi...@apache.org>]

nseekhao commented on PR #7612:
URL: https://github.com/apache/arrow-datafusion/pull/7612#issuecomment-1751439292

   @alamb I extracted the predicate splits from the `from_substrait_rel()` so the code is easier to read. Unfortunately, I couldn't use the function `split_eq_and_noneq_join_predicate()` (from your [ref](https://docs.rs/datafusion/latest/datafusion/optimizer/extract_equijoin_predicate/struct.ExtractEquijoinPredicate.html)) directly because the function will put the equal condition with `nulls_equal_nulls = true` (`IsNotDistinctFrom`) into a join filter, as opposed to putting it in the join condition.
   
   As for the test, I added a test function to be used when join has a non-equi condition, to ensure that the join filter does not mistakenly get embedded into a Substrait plan as a `post_join_filter`. LMK if this is what you had in mind, otherwise we can discuss further changes. Thanks for the review!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org