You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/26 10:21:07 UTC
[GitHub] [dubbo-go] LaurenceLiZhixin opened a new pull request #1344: ftr: triple multi params support
LaurenceLiZhixin opened a new pull request #1344:
URL: https://github.com/apache/dubbo-go/pull/1344
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1344: ftr: triple multi params support
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1344:
URL: https://github.com/apache/dubbo-go/pull/1344#discussion_r676919997
##########
File path: protocol/dubbo3/dubbo3_protocol.go
##########
@@ -99,18 +99,18 @@ func (dp *DubboProtocol) Export(invoker protocol.Invoker) protocol.Exporter {
valueOf := reflect.ValueOf(service)
typeOf := valueOf.Type()
numField := valueOf.NumMethod()
- tripleService := &Dubbo3HessianService{proxyImpl: invoker}
+ tripleService := &UnaryService{proxyImpl: invoker}
for i := 0; i < numField; i++ {
ft := typeOf.Method(i)
if ft.Name == "Reference" {
continue
}
- // num out is checked in common/rpc_service.go
- if ft.Type.NumIn() != 3 {
Review comment:
why delete the check cond?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #1344: ftr: triple multi params support
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #1344:
URL: https://github.com/apache/dubbo-go/pull/1344#discussion_r678925040
##########
File path: protocol/dubbo3/dubbo3_protocol.go
##########
@@ -99,18 +99,18 @@ func (dp *DubboProtocol) Export(invoker protocol.Invoker) protocol.Exporter {
valueOf := reflect.ValueOf(service)
typeOf := valueOf.Type()
numField := valueOf.NumMethod()
- tripleService := &Dubbo3HessianService{proxyImpl: invoker}
+ tripleService := &UnaryService{proxyImpl: invoker}
for i := 0; i < numField; i++ {
ft := typeOf.Method(i)
if ft.Name == "Reference" {
continue
}
- // num out is checked in common/rpc_service.go
- if ft.Type.NumIn() != 3 {
Review comment:
awesome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1344: ftr: triple multi params support
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1344:
URL: https://github.com/apache/dubbo-go/pull/1344#issuecomment-886637845
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1344](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be8d03c) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/6b1d9dd506d8c680a5455d7fb9b6240cc426c367?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b1d9dd) will **decrease** coverage by `0.12%`.
> The diff coverage is `65.41%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1344 +/- ##
==========================================
- Coverage 56.09% 55.97% -0.13%
==========================================
Files 273 278 +5
Lines 12779 15298 +2519
==========================================
+ Hits 7169 8563 +1394
- Misses 4705 5810 +1105
- Partials 905 925 +20
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_remote.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9yZW1vdGUuZ28=) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service\_proxy\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlX3Byb3h5X2ZhY3RvcnkuZ28=) | `0.00% <0.00%> (ø)` | |
| [config/config\_api.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19hcGkuZ28=) | `76.71% <ø> (-1.01%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `49.80% <0.00%> (+2.43%)` | :arrow_up: |
| [filter/auth/consumer\_sign\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvY29uc3VtZXJfc2lnbl9maWx0ZXIuZ28=) | `44.44% <0.00%> (ø)` | |
| [filter/auth/sign\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvc2lnbl91dGlsLmdv) | `62.96% <ø> (ø)` | |
| [...ter/handler/rejected\_execution\_handler\_only\_log.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfb25seV9sb2cuZ28=) | `100.00% <ø> (ø)` | |
| [filter/tps/limiter/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3Rwcy9saW1pdGVyL21vY2suZ28=) | `0.00% <ø> (ø)` | |
| ... and [320 more](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9aeb7ff...be8d03c](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin merged pull request #1344: ftr: triple multi params support
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin merged pull request #1344:
URL: https://github.com/apache/dubbo-go/pull/1344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1344: ftr: triple multi params support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1344:
URL: https://github.com/apache/dubbo-go/pull/1344#issuecomment-886637845
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1344](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be8d03c) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/6b1d9dd506d8c680a5455d7fb9b6240cc426c367?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b1d9dd) will **decrease** coverage by `0.12%`.
> The diff coverage is `65.41%`.
> :exclamation: Current head be8d03c differs from pull request most recent head e4078e2. Consider uploading reports for the commit e4078e2 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1344 +/- ##
==========================================
- Coverage 56.09% 55.97% -0.13%
==========================================
Files 273 278 +5
Lines 12779 15298 +2519
==========================================
+ Hits 7169 8563 +1394
- Misses 4705 5810 +1105
- Partials 905 925 +20
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_remote.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9yZW1vdGUuZ28=) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service\_proxy\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlX3Byb3h5X2ZhY3RvcnkuZ28=) | `0.00% <0.00%> (ø)` | |
| [config/config\_api.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19hcGkuZ28=) | `76.71% <ø> (-1.01%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `49.80% <0.00%> (+2.43%)` | :arrow_up: |
| [filter/auth/consumer\_sign\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvY29uc3VtZXJfc2lnbl9maWx0ZXIuZ28=) | `44.44% <0.00%> (ø)` | |
| [filter/auth/sign\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvc2lnbl91dGlsLmdv) | `62.96% <ø> (ø)` | |
| [...ter/handler/rejected\_execution\_handler\_only\_log.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfb25seV9sb2cuZ28=) | `100.00% <ø> (ø)` | |
| [filter/tps/limiter/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3Rwcy9saW1pdGVyL21vY2suZ28=) | `0.00% <ø> (ø)` | |
| ... and [320 more](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ebce04e...e4078e2](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1344: ftr: triple multi params support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1344:
URL: https://github.com/apache/dubbo-go/pull/1344#issuecomment-886637845
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1344](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be8d03c) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/6b1d9dd506d8c680a5455d7fb9b6240cc426c367?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b1d9dd) will **decrease** coverage by `0.12%`.
> The diff coverage is `65.41%`.
> :exclamation: Current head be8d03c differs from pull request most recent head 8128fcf. Consider uploading reports for the commit 8128fcf to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1344 +/- ##
==========================================
- Coverage 56.09% 55.97% -0.13%
==========================================
Files 273 278 +5
Lines 12779 15298 +2519
==========================================
+ Hits 7169 8563 +1394
- Misses 4705 5810 +1105
- Partials 905 925 +20
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_remote.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9yZW1vdGUuZ28=) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service\_proxy\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlX3Byb3h5X2ZhY3RvcnkuZ28=) | `0.00% <0.00%> (ø)` | |
| [config/config\_api.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19hcGkuZ28=) | `76.71% <ø> (-1.01%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `49.80% <0.00%> (+2.43%)` | :arrow_up: |
| [filter/auth/consumer\_sign\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvY29uc3VtZXJfc2lnbl9maWx0ZXIuZ28=) | `44.44% <0.00%> (ø)` | |
| [filter/auth/sign\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvc2lnbl91dGlsLmdv) | `62.96% <ø> (ø)` | |
| [...ter/handler/rejected\_execution\_handler\_only\_log.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfb25seV9sb2cuZ28=) | `100.00% <ø> (ø)` | |
| [filter/tps/limiter/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3Rwcy9saW1pdGVyL21vY2suZ28=) | `0.00% <ø> (ø)` | |
| ... and [320 more](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ebce04e...8128fcf](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1344: ftr: triple multi params support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1344:
URL: https://github.com/apache/dubbo-go/pull/1344#issuecomment-886637845
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1344](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be8d03c) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/6b1d9dd506d8c680a5455d7fb9b6240cc426c367?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b1d9dd) will **decrease** coverage by `0.12%`.
> The diff coverage is `65.41%`.
> :exclamation: Current head be8d03c differs from pull request most recent head 13518cd. Consider uploading reports for the commit 13518cd to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1344 +/- ##
==========================================
- Coverage 56.09% 55.97% -0.13%
==========================================
Files 273 278 +5
Lines 12779 15298 +2519
==========================================
+ Hits 7169 8563 +1394
- Misses 4705 5810 +1105
- Partials 905 925 +20
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_remote.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9yZW1vdGUuZ28=) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service\_proxy\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlX3Byb3h5X2ZhY3RvcnkuZ28=) | `0.00% <0.00%> (ø)` | |
| [config/config\_api.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19hcGkuZ28=) | `76.71% <ø> (-1.01%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `49.80% <0.00%> (+2.43%)` | :arrow_up: |
| [filter/auth/consumer\_sign\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvY29uc3VtZXJfc2lnbl9maWx0ZXIuZ28=) | `44.44% <0.00%> (ø)` | |
| [filter/auth/sign\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvc2lnbl91dGlsLmdv) | `62.96% <ø> (ø)` | |
| [...ter/handler/rejected\_execution\_handler\_only\_log.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfb25seV9sb2cuZ28=) | `100.00% <ø> (ø)` | |
| [filter/tps/limiter/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3Rwcy9saW1pdGVyL21vY2suZ28=) | `0.00% <ø> (ø)` | |
| ... and [320 more](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ebce04e...13518cd](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1344: ftr: triple multi params support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1344:
URL: https://github.com/apache/dubbo-go/pull/1344#issuecomment-886637845
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1344](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be8d03c) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/6b1d9dd506d8c680a5455d7fb9b6240cc426c367?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6b1d9dd) will **decrease** coverage by `0.12%`.
> The diff coverage is `65.41%`.
> :exclamation: Current head be8d03c differs from pull request most recent head 2066f0c. Consider uploading reports for the commit 2066f0c to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1344 +/- ##
==========================================
- Coverage 56.09% 55.97% -0.13%
==========================================
Files 273 278 +5
Lines 12779 15298 +2519
==========================================
+ Hits 7169 8563 +1394
- Misses 4705 5810 +1105
- Partials 905 925 +20
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_remote.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9yZW1vdGUuZ28=) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/metadata\_service\_proxy\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlX3Byb3h5X2ZhY3RvcnkuZ28=) | `0.00% <0.00%> (ø)` | |
| [config/config\_api.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19hcGkuZ28=) | `76.71% <ø> (-1.01%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `49.80% <0.00%> (+2.43%)` | :arrow_up: |
| [filter/auth/consumer\_sign\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvY29uc3VtZXJfc2lnbl9maWx0ZXIuZ28=) | `44.44% <0.00%> (ø)` | |
| [filter/auth/sign\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvc2lnbl91dGlsLmdv) | `62.96% <ø> (ø)` | |
| [...ter/handler/rejected\_execution\_handler\_only\_log.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfb25seV9sb2cuZ28=) | `100.00% <ø> (ø)` | |
| [filter/tps/limiter/mock.go](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3Rwcy9saW1pdGVyL21vY2suZ28=) | `0.00% <ø> (ø)` | |
| ... and [320 more](https://codecov.io/gh/apache/dubbo-go/pull/1344/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9aeb7ff...2066f0c](https://codecov.io/gh/apache/dubbo-go/pull/1344?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1344: ftr: triple multi params support
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1344:
URL: https://github.com/apache/dubbo-go/pull/1344#discussion_r678891263
##########
File path: protocol/dubbo3/dubbo3_protocol.go
##########
@@ -99,18 +99,18 @@ func (dp *DubboProtocol) Export(invoker protocol.Invoker) protocol.Exporter {
valueOf := reflect.ValueOf(service)
typeOf := valueOf.Type()
numField := valueOf.NumMethod()
- tripleService := &Dubbo3HessianService{proxyImpl: invoker}
+ tripleService := &UnaryService{proxyImpl: invoker}
for i := 0; i < numField; i++ {
ft := typeOf.Method(i)
if ft.Name == "Reference" {
continue
}
- // num out is checked in common/rpc_service.go
- if ft.Type.NumIn() != 3 {
Review comment:
Thisk Block limit the number of method input params, if not 1 param, it would panic.
Now, we support any number of param.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org