You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "mridulm (via GitHub)" <gi...@apache.org> on 2023/10/20 01:58:20 UTC

[PR] SPARK-45613: Expose DeterministicLevel as a DeveloperApi [spark]

mridulm opened a new pull request, #43461:
URL: https://github.com/apache/spark/pull/43461

   ### What changes were proposed in this pull request?
   Expose `DeterministicLevel` as a `DeveloperApi`
   
   ### Why are the changes needed?
   `RDD.getOutputDeterministicLevel` is a `DeveloperApi` - unfortunately, this cannot be overridden by users as `DeterministicLevel` is `private[spark]`.
   Expose it as a `DeveloperApi` to allow users to override this.
   
   ### Does this PR introduce _any_ user-facing change?
   Yes, updates the visibility of `DeterministicLevel`
   
   ### How was this patch tested?
   Visibility change, no test required.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] SPARK-45613: Expose DeterministicLevel as a DeveloperApi [spark]

Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm commented on PR #43461:
URL: https://github.com/apache/spark/pull/43461#issuecomment-1771956002

   +CC @cloud-fan, @Ngone51, @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45613][CORE] Expose DeterministicLevel as a DeveloperApi [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43461:
URL: https://github.com/apache/spark/pull/43461#issuecomment-1772153317

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45613][CORE] Expose DeterministicLevel as a DeveloperApi [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #43461: [SPARK-45613][CORE] Expose DeterministicLevel as a DeveloperApi
URL: https://github.com/apache/spark/pull/43461


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45613][CORE] Expose DeterministicLevel as a DeveloperApi [spark]

Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm commented on PR #43461:
URL: https://github.com/apache/spark/pull/43461#issuecomment-1772712841

   Thanks @HyukjinKwon, @cloud-fan  !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org