You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mliesenberg <gi...@git.apache.org> on 2016/02/27 20:56:37 UTC
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
GitHub user mliesenberg opened a pull request:
https://github.com/apache/flink/pull/1729
FLINK-3529 Add template for pull requests
- added markdown as discussed on the mailing list
- added template to list of excluded files of rat plugin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mliesenberg/flink FLINK-3529-add-pr-template
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1729.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1729
----
commit 66abd552daad7c80d58de5a72e572c913f34c9e8
Author: Martin Liesenberg <ma...@gmail.com>
Date: 2016-02-27T14:51:45Z
FLINK-3529 Add template for pull requests and add it to excluded file of rat plugin
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1729#discussion_r54353877
--- Diff: PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,18 @@
+Thanks for contributing to Apache Flink, before you open your PR please kindly take into consideration the following check list.
+Once you are sure, all items on the list can be checked, feel free to open your PR. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
+In addition to going through the list, please provide a meaningful description of your changes.
+
+- [ ] General
+ - The pull request references the related JIRA issue
+ - The pull request addresses only one issue
+ - Each commit in the PR has a meaningful commit message
+
+- [ ] Documentation
+ - Documentation has been added for new functionality
+ - Old documentation updated affected by the pull request has been updated
--- End diff --
Remove first occurrence of "updated".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-199850351
+1
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1729#discussion_r54551538
--- Diff: PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,18 @@
+Thanks for contributing to Apache Flink, before you open your PR please kindly take into consideration the following check list.
--- End diff --
Suggestion: Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1729#discussion_r55687974
--- Diff: CONTRIBUTING.md ---
@@ -8,4 +8,4 @@ To make the process smooth for the project *committers* (those who review and ac
Please check out the [How to Contribute guide](http://flink.apache.org/how-to-contribute.html) to understand how contributions are made.
There is also a list of [Coding Guidelines](http://flink.apache.org/coding-guidelines.html) that you should follow.
-
+Moreover, there's a [check list](PULL_REQUEST_TEMPLATE.md) of what to do before opening a pull request here
--- End diff --
This is not a full sentence. How about: "For pull requests, there is a [check list](PULL_REQUEST_TEMPLATE.md) with criteria taken from the How to Contribute Guide and the Coding Guidelines."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1729#discussion_r54353866
--- Diff: PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,18 @@
+Thanks for contributing to Apache Flink, before you open your PR please kindly take into consideration the following check list.
--- End diff --
I would split this in 2 sentences. i.e. Before...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1729#discussion_r55688207
--- Diff: PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,18 @@
+Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
+If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
+In addition to going through the list, please provide a meaningful description of your changes.
+
+- [ ] General
+ - The pull request references the related JIRA issue
+ - The pull request addresses only one issue
+ - Each commit in the PR has a meaningful commit message
+
+- [ ] Documentation
+ - Documentation has been added for new functionality
+ - Old documentation affected by the pull request has been updated
+ - JavaDoc for public methods has been added
+
+- [ ] Tests & Build
+ - Functionality added by the pull request is covered by tests
+ - `mvn clean verify` has been executed successfully locally
+ - or a Travis build has passed
--- End diff --
Could you combine the last two in a single bullet point?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by mliesenberg <gi...@git.apache.org>.
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-199710458
thanks. removed the regression, squashed and rebased on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1729#discussion_r56953234
--- Diff: CONTRIBUTING.md ---
@@ -7,5 +7,6 @@ To make the process smooth for the project *committers* (those who review and ac
## Contribution Guidelines
Please check out the [How to Contribute guide](http://flink.apache.org/how-to-contribute.html) to understand how contributions are made.
+<<<<<<< Updated upstream
--- End diff --
Looks like a left-over of a merge/rebase conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1729#discussion_r54551542
--- Diff: PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,18 @@
+Thanks for contributing to Apache Flink, before you open your PR please kindly take into consideration the following check list.
+Once you are sure, all items on the list can be checked, feel free to open your PR. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
--- End diff --
Suggestion: If your changes take all of the items into account, feel free to open your pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1729
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1729#discussion_r54353870
--- Diff: PULL_REQUEST_TEMPLATE.md ---
@@ -0,0 +1,18 @@
+Thanks for contributing to Apache Flink, before you open your PR please kindly take into consideration the following check list.
+Once you are sure, all items on the list can be checked, feel free to open your PR. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
--- End diff --
Remove comma after sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-199711790
Good to merge in my opinion. If there are no other comments on the template, I will merge the PR in a few days.
Thanks again @mliesenberg!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-205278645
Will merge this if there are no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-191639327
Should be a link from CONTRIBUTING page to this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-199707109
I like the template! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by mliesenberg <gi...@git.apache.org>.
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-194873275
build failed because all jobs failed the `ClassLoaderITCase.testJobsWithCustomClassLoader` test.
I guess this is unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by mliesenberg <gi...@git.apache.org>.
Github user mliesenberg commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-191670860
Thanks for the feedback, I will update the PR tonight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-194879749
Yes, the test failures are unrelated. Looks good. Could you incorporate the last comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3529 Add template for pull requests
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1729#issuecomment-199715433
Good to merge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---