[GitHub] [maven-common-artifact-filters] rfscholte commented on a change in pull request #15: Big speed improvements for patterns that do not contain any wildcard

[GitBox <gi...@apache.org>]

rfscholte commented on a change in pull request #15:
URL: https://github.com/apache/maven-common-artifact-filters/pull/15#discussion_r527831634



##########
File path: src/main/java/org/apache/maven/shared/artifact/filter/PatternIncludesArtifactFilter.java
##########
@@ -107,322 +147,783 @@ public boolean include( final Artifact artifact )
      */
     protected boolean patternMatches( final Artifact artifact )
     {
-        return positiveMatch( artifact ) == Boolean.TRUE || negativeMatch( artifact ) == Boolean.FALSE;
+        // Check if the main artifact matches
+        char[][] tokens = new char[][] {

Review comment:
       `tokens` doesn't describe this clearly, espacially if the order matters. Something like `gatvAsCharArray` would at least help to understand how it is used later on on the code. (sometimes type and version are switched, so better to add that explcitly in the variable name)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org