[GitHub] [kafka] iprithv commented on a change in pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields

[GitBox <gi...@apache.org>]

iprithv commented on a change in pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#discussion_r520336051



##########
File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala
##########
@@ -257,8 +257,11 @@ object DumpLogSegments {
             }
             lastOffset = record.offset
 
-            print(s"$RecordIndent offset: ${record.offset} ${batch.timestampType}: ${record.timestamp} " +
-              s"keysize: ${record.keySize} valuesize: ${record.valueSize}")
+            print(s"$RecordIndent offset: ${record.offset} baseOffset: ${batch.baseOffset} lastOffset: ${batch.lastOffset} baseSequence: ${} ${batch.baseSequence}" +
+             s" lastSequence: ${batch.lastSequence} producerEpoch: ${batch.producerEpoch} partitionLeaderEpoch: ${batch.partitionLeaderEpoch} position: ${validBytes} " +
+             s" ${batch.timestampType}: ${record.timestamp} isvalid: ${record.isValid}"+
+             s" keysize: ${record.keySize} valuesize: ${record.valueSize} size: ${batch.sizeInBytes} magic: ${batch.magic} " +

Review comment:
       @chia7712  Have seperated the record details from batch details. Also changed the entries to camel case. Please review this. Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org