You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/05 01:04:38 UTC
[GitHub] [geode] davebarnes97 opened a new pull request #6095: GEODE-8953: Re-introduce transaction details regarding non-transactional changes
davebarnes97 opened a new pull request #6095:
URL: https://github.com/apache/geode/pull/6095
Restore some cautionary text that was removed during an earlier re-write of the transaction section.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 merged pull request #6095: GEODE-8953: Re-introduce transaction details regarding non-transactional changes
Posted by GitBox <gi...@apache.org>.
davebarnes97 merged pull request #6095:
URL: https://github.com/apache/geode/pull/6095
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #6095: GEODE-8953: Re-introduce transaction details regarding non-transactional changes
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #6095:
URL: https://github.com/apache/geode/pull/6095#discussion_r588596046
##########
File path: geode-docs/developing/transactions/design_considerations.html.md.erb
##########
@@ -117,6 +118,21 @@ immediately after the commit.
A transaction disables expiration on any region entries affected
by the transaction.
+## <a id="transactions-nontransactions" class="no-quick-link"></a>Mixing Transactions with Nontransactional Operations
Review comment:
Good catch, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] karensmolermiller commented on a change in pull request #6095: GEODE-8953: Re-introduce transaction details regarding non-transactional changes
Posted by GitBox <gi...@apache.org>.
karensmolermiller commented on a change in pull request #6095:
URL: https://github.com/apache/geode/pull/6095#discussion_r588549180
##########
File path: geode-docs/developing/transactions/design_considerations.html.md.erb
##########
@@ -117,6 +118,21 @@ immediately after the commit.
A transaction disables expiration on any region entries affected
by the transaction.
+## <a id="transactions-nontransactions" class="no-quick-link"></a>Mixing Transactions with Nontransactional Operations
Review comment:
Add hyphen to "Nontransactional" to become Non-transactional.
##########
File path: geode-docs/developing/transactions/design_considerations.html.md.erb
##########
@@ -117,6 +118,21 @@ immediately after the commit.
A transaction disables expiration on any region entries affected
by the transaction.
+## <a id="transactions-nontransactions" class="no-quick-link"></a>Mixing Transactions with Nontransactional Operations
+
+For best performance, non-transactional operations do not acquire the exclusive locks used to check
+for conflicts in a transaction. A transaction operating on the same data as a non-transactional actor
+is unable to detect the conflict caused by a non-transactional operation.
+
+A user application should adopt the policy of always using transactions or no transactions at all
Review comment:
The phrase "no transactions at all" feels awkward to me. Maybe better (?):
> A user application should adopt the policy of always using transactions or the policy of not using transactions at all for certain regions or sets of entries, so transactional entries will not be modified by operations
outside of the transaction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #6095: GEODE-8953: Re-introduce transaction details regarding non-transactional changes
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #6095:
URL: https://github.com/apache/geode/pull/6095#discussion_r588598937
##########
File path: geode-docs/developing/transactions/design_considerations.html.md.erb
##########
@@ -117,6 +118,21 @@ immediately after the commit.
A transaction disables expiration on any region entries affected
by the transaction.
+## <a id="transactions-nontransactions" class="no-quick-link"></a>Mixing Transactions with Nontransactional Operations
+
+For best performance, non-transactional operations do not acquire the exclusive locks used to check
+for conflicts in a transaction. A transaction operating on the same data as a non-transactional actor
+is unable to detect the conflict caused by a non-transactional operation.
+
+A user application should adopt the policy of always using transactions or no transactions at all
Review comment:
I've replaced this paragraph with:
If using transactions, an application should adopt the policy of designating certain regions or sets of entries
exclusively for transactional puts, updates, and deletions, so transactional entries will not be modified by non-transactional.
operations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org