You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/30 14:49:12 UTC
[GitHub] [camel-k] nicolaferraro opened a new pull request #1380: Fix #1379:
make download link available also when installing from operator hub
nicolaferraro opened a new pull request #1380: Fix #1379: make download link available also when installing from operator hub
URL: https://github.com/apache/camel-k/pull/1380
…rator hub
<!-- Description -->
Fix #1379
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
CLI download links are now published after installing from operator Hub on OpenShift
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] nicolaferraro commented on a change in pull request
#1380: Fix #1379: make download link available also when installing from
operator hub
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on a change in pull request #1380: Fix #1379: make download link available also when installing from operator hub
URL: https://github.com/apache/camel-k/pull/1380#discussion_r400254180
##########
File path: deploy/olm-catalog/camel-k/1.0.0-snapshot/camel-k.v1.0.0-snapshot.clusterserviceversion.yaml
##########
@@ -385,6 +401,14 @@ spec:
- patch
- update
- watch
+ - apiGroups:
+ - rbac.authorization.k8s.io
+ resourceNames:
+ - system:image-builder
+ resources:
+ - clusterroles
+ verbs:
+ - bind
Review comment:
@astefanutti this is auto-generated from the OLM role file. Does this need to be a role or a clusterrole? I'm not sure, since you deal with a cluster resource but you want to bind it locally...
I've left it as you did
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] nicolaferraro merged pull request #1380: Fix #1379: make
download link available also when installing from operator hub
Posted by GitBox <gi...@apache.org>.
nicolaferraro merged pull request #1380: Fix #1379: make download link available also when installing from operator hub
URL: https://github.com/apache/camel-k/pull/1380
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] astefanutti commented on a change in pull request #1380:
Fix #1379: make download link available also when installing from operator
hub
Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #1380: Fix #1379: make download link available also when installing from operator hub
URL: https://github.com/apache/camel-k/pull/1380#discussion_r400291602
##########
File path: deploy/olm-catalog/camel-k/1.0.0-snapshot/camel-k.v1.0.0-snapshot.clusterserviceversion.yaml
##########
@@ -385,6 +401,14 @@ spec:
- patch
- update
- watch
+ - apiGroups:
+ - rbac.authorization.k8s.io
+ resourceNames:
+ - system:image-builder
+ resources:
+ - clusterroles
+ verbs:
+ - bind
Review comment:
IIRC, I think a role is enough as it is granted for the operator SA in its namespace.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services