You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/30 23:43:30 UTC
[GitHub] [iceberg] guilload commented on a change in pull request #1270: Remove conflicting dependency and unnecessary checked exception
guilload commented on a change in pull request #1270:
URL: https://github.com/apache/iceberg/pull/1270#discussion_r463330144
##########
File path: mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java
##########
@@ -41,11 +39,7 @@
public void initialize(@Nullable Configuration configuration, Properties serDeProperties) throws SerDeException {
final Table table;
- try {
- table = TableResolver.resolveTableFromConfiguration(configuration, serDeProperties);
- } catch (IOException e) {
- throw new UncheckedIOException("Unable to resolve table from configuration: ", e);
- }
+ table = TableResolver.resolveTableFromConfiguration(configuration, serDeProperties);
Review comment:
```suggestion
Table table = TableResolver.resolveTableFromConfiguration(configuration, serDeProperties);
```
##########
File path: mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java
##########
@@ -41,11 +39,7 @@
public void initialize(@Nullable Configuration configuration, Properties serDeProperties) throws SerDeException {
final Table table;
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org