You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/02/13 21:41:19 UTC
[kudu-CR] [build-support] KUDU-2699 introduce TIDY build type
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12471
Change subject: [build-support] KUDU-2699 introduce TIDY build type
......................................................................
[build-support] KUDU-2699 introduce TIDY build type
This changelist introduces a new TIDY build type to facilitate running
clang_tidy_gerrit.py from the kudu-tidy-bot Jenkins job by
jenkins.kudu.apache.org. The idea is to make sure all auto-generated
header files are present before running the clang-tidy tool on the
Kudu C++ source files.
Change-Id: I9b364620c9fb92202cacf0286df292dd4cc9952b
---
M CMakeLists.txt
M build-support/jenkins/build-and-test.sh
2 files changed, 29 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/12471/1
--
To view, visit http://gerrit.cloudera.org:8080/12471
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b364620c9fb92202cacf0286df292dd4cc9952b
Gerrit-Change-Number: 12471
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [build-support] KUDU-2699 introduce TIDY build type
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12471 )
Change subject: [build-support] KUDU-2699 introduce TIDY build type
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12471/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12471/5//COMMIT_MSG@20
PS5, Line 20: but
bot
--
To view, visit http://gerrit.cloudera.org:8080/12471
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b364620c9fb92202cacf0286df292dd4cc9952b
Gerrit-Change-Number: 12471
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 14 Feb 2019 00:19:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build-support] KUDU-2699 introduce TIDY build type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12471
to look at the new patch set (#6).
Change subject: [build-support] KUDU-2699 introduce TIDY build type
......................................................................
[build-support] KUDU-2699 introduce TIDY build type
This changelist introduces a new TIDY build type to facilitate running
clang_tidy_gerrit.py from the kudu-tidy-bot Jenkins job by
jenkins.kudu.apache.org. The idea is to make sure all auto-generated
header files are present before running the clang-tidy tool on the
Kudu C++ source files.
As Adar noticed, our development process is such that new work goes
into master and any commits to release branches are pure backports.
There's not much point in running clang-tidy on those backports.
So, the proposal is to simply run the kudu-tidy-bot job only on
the changes in the master branch. That entails updating the
configuration of the kudu-tidy-bot Jenkins job after this change
is pushed into the repo.
The corresponding command for the config for the kudu-tidy-bot job is:
----------------------------------------------------------------------
\#!/bin/bash
export TIDYBOT_PASSWORD=<hidden>
export PATH=/usr/lib/ccache:$PATH
ccache -M 50G
set -ex
export BUILD_TYPE=TIDY
build-support/jenkins/build-and-test.sh
----------------------------------------------------------------------
Change-Id: I9b364620c9fb92202cacf0286df292dd4cc9952b
---
M CMakeLists.txt
M build-support/jenkins/build-and-test.sh
2 files changed, 28 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/12471/6
--
To view, visit http://gerrit.cloudera.org:8080/12471
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9b364620c9fb92202cacf0286df292dd4cc9952b
Gerrit-Change-Number: 12471
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build-support] KUDU-2699 introduce TIDY build type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12471
to look at the new patch set (#5).
Change subject: [build-support] KUDU-2699 introduce TIDY build type
......................................................................
[build-support] KUDU-2699 introduce TIDY build type
This changelist introduces a new TIDY build type to facilitate running
clang_tidy_gerrit.py from the kudu-tidy-bot Jenkins job by
jenkins.kudu.apache.org. The idea is to make sure all auto-generated
header files are present before running the clang-tidy tool on the
Kudu C++ source files.
As Adar noticed, our development process is such that new work goes
into master and any commits to release branches are pure backports.
There's not much point in running clang-tidy on those backports.
So, the proposal is to simply run the kudu-tidy-but job only on
the changes in the master branch. That entails updating the
configuration of the kudu-tidy-but Jenkins job after this change
is pushed into the repo.
The corresponding command for the config for the kudu-tidy-but job is:
----------------------------------------------------------------------
\#!/bin/bash
export TIDYBOT_PASSWORD=<hidden>
export PATH=/usr/lib/ccache:$PATH
ccache -M 50G
set -ex
export BUILD_TYPE=TIDY
build-support/jenkins/build-and-test.sh
----------------------------------------------------------------------
Change-Id: I9b364620c9fb92202cacf0286df292dd4cc9952b
---
M CMakeLists.txt
M build-support/jenkins/build-and-test.sh
2 files changed, 28 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/12471/5
--
To view, visit http://gerrit.cloudera.org:8080/12471
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9b364620c9fb92202cacf0286df292dd4cc9952b
Gerrit-Change-Number: 12471
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build-support] KUDU-2699 introduce TIDY build type
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12471 )
Change subject: [build-support] KUDU-2699 introduce TIDY build type
......................................................................
Patch Set 1:
Also bear in mind that kudu-tidy-bot is currently configured to run on Gerrit changes to _any_ branch. So if this change is merged, we'll need to deal with older branches somehow. Either by backporting this change, or by reconfiguring kudu-tidy-bot to only run against master.
--
To view, visit http://gerrit.cloudera.org:8080/12471
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b364620c9fb92202cacf0286df292dd4cc9952b
Gerrit-Change-Number: 12471
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 13 Feb 2019 21:54:53 +0000
Gerrit-HasComments: No
[kudu-CR] [build-support] KUDU-2699 introduce TIDY build type
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12471 )
Change subject: [build-support] KUDU-2699 introduce TIDY build type
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12471
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b364620c9fb92202cacf0286df292dd4cc9952b
Gerrit-Change-Number: 12471
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 14 Feb 2019 01:10:30 +0000
Gerrit-HasComments: No
[kudu-CR] [build-support] KUDU-2699 introduce TIDY build type
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12471 )
Change subject: [build-support] KUDU-2699 introduce TIDY build type
......................................................................
Patch Set 1:
Can you also post your proposed kudu-tidy-bot job config so it can be reviewed alongside the build-and-test.sh changes? As a comment in this gerrit is fine; no need to get fancy.
--
To view, visit http://gerrit.cloudera.org:8080/12471
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b364620c9fb92202cacf0286df292dd4cc9952b
Gerrit-Change-Number: 12471
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 13 Feb 2019 21:49:51 +0000
Gerrit-HasComments: No
[kudu-CR] [build-support] KUDU-2699 introduce TIDY build type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12471 )
Change subject: [build-support] KUDU-2699 introduce TIDY build type
......................................................................
[build-support] KUDU-2699 introduce TIDY build type
This changelist introduces a new TIDY build type to facilitate running
clang_tidy_gerrit.py from the kudu-tidy-bot Jenkins job by
jenkins.kudu.apache.org. The idea is to make sure all auto-generated
header files are present before running the clang-tidy tool on the
Kudu C++ source files.
As Adar noticed, our development process is such that new work goes
into master and any commits to release branches are pure backports.
There's not much point in running clang-tidy on those backports.
So, the proposal is to simply run the kudu-tidy-bot job only on
the changes in the master branch. That entails updating the
configuration of the kudu-tidy-bot Jenkins job after this change
is pushed into the repo.
The corresponding command for the config for the kudu-tidy-bot job is:
----------------------------------------------------------------------
\#!/bin/bash
export TIDYBOT_PASSWORD=<hidden>
export PATH=/usr/lib/ccache:$PATH
ccache -M 50G
set -ex
export BUILD_TYPE=TIDY
build-support/jenkins/build-and-test.sh
----------------------------------------------------------------------
Change-Id: I9b364620c9fb92202cacf0286df292dd4cc9952b
Reviewed-on: http://gerrit.cloudera.org:8080/12471
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M CMakeLists.txt
M build-support/jenkins/build-and-test.sh
2 files changed, 28 insertions(+), 6 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12471
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b364620c9fb92202cacf0286df292dd4cc9952b
Gerrit-Change-Number: 12471
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)