[GitHub] [lucene-solr-operator] HoustonPutman commented on a change in pull request #226: Add terminationGracePeriod option, and use it when killing Solr.

[GitBox <gi...@apache.org>]

HoustonPutman commented on a change in pull request #226:
URL: https://github.com/apache/lucene-solr-operator/pull/226#discussion_r583151756



##########
File path: controllers/util/solr_util.go
##########
@@ -266,6 +270,9 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud, solrCloudStatus *solr.SolrCl
 	solrHostName := solrCloud.AdvertisedNodeHost("$(POD_HOSTNAME)")
 	solrAdressingPort := solrCloud.NodePort()
 
+	// Solr can take longer than SOLR_STOP_WAIT to run solr stop, give it a few extra seconds before forcefully killing the pod.
+	solrStopWait := terminationGracePeriod - 5

Review comment:
       maybe we set a minimum possible value for terminationGracePeriod? Like 10 seconds?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org