DO NOT REPLY [Bug 36306] - Collection of fixes to address Checkstyle complaints

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=36306>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36306





------- Additional Comments From fzammetti@omnytex.com  2006-02-09 07:54 -------
I know there has been some recent headway in all this, which is great!  I also 
know that Wendy has offered to deal with some of the remaining issues, which 
seem to almost entirely be simple commenting fixups (or additions of missing 
comments).  I have offered to help her in that task this weekend.  Initially 
I'm thinking of tackling the action package.  Does that present any conflict 
for what you planned Wendy?

One question... do we need to define any style rules for comments?  For 
instance, I tend to want to line things up, i.e. the parameter, return and 
exception comments on a method I like to have lined up in terms of their 
starting column... somestimes this leads to some short lines though because of 
making sure to keep the line lengths below 80.  Other people prefer not 
bothering with that and let it simply flow naturally.  Do we have a preference 
here?  More to the point, will Jalopy enforce any particular style?  If it 
does I suppose this is a moot point, it would work either way.

Similarly, what about the order of tokens?  @parameter, @return, @exception 
vs. @exception, @parameter, @return for example.  What about spaces between 
the description of the method and the start of the tokens?

Am I perhaps being too anal about it? :)  Maybe none of this is important.  
Like I said, if Jalopy can deal with all of this, then no worries I suppose.  
Just want to make sure what I do is quickly and easily acceptable is all, and 
consistent with the effort Wendy and/or others put in.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org