You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2024/10/30 13:41:27 UTC

[PR] [MNG-8362] Adding some missing config properties [maven]

cstamas opened a new pull request, #1861:
URL: https://github.com/apache/maven/pull/1861

   To have them listed in generated docs.
   
   ---
   
   https://issues.apache.org/jira/browse/MNG-8362


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MNG-8362] Adding some missing config properties [maven]

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #1861:
URL: https://github.com/apache/maven/pull/1861


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MNG-8362] Adding some missing config properties [maven]

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #1861:
URL: https://github.com/apache/maven/pull/1861#discussion_r1825814072


##########
api/maven-api-core/src/main/java/org/apache/maven/api/Constants.java:
##########
@@ -386,5 +386,26 @@ public final class Constants {
     @Config(type = "java.lang.Boolean", defaultValue = "true")
     public static final String MAVEN_CONSUMER_POM = "maven.consumer.pom";
 
+    /**
+     * User property for disabling version resolver cache.
+     *
+     * @since 3.0.0
+     */
+    @Config(type = "java.lang.Boolean", defaultValue = "false")
+    public static final String MAVEN_VERSION_RESOLVER_NO_CACHE = "aether.versionResolver.noCache";

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MNG-8362] Adding some missing config properties [maven]

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #1861:
URL: https://github.com/apache/maven/pull/1861#discussion_r1825811135


##########
api/maven-api-core/src/main/java/org/apache/maven/api/Constants.java:
##########
@@ -386,5 +386,26 @@ public final class Constants {
     @Config(type = "java.lang.Boolean", defaultValue = "true")
     public static final String MAVEN_CONSUMER_POM = "maven.consumer.pom";
 
+    /**
+     * User property for disabling version resolver cache.
+     *
+     * @since 3.0.0
+     */
+    @Config(type = "java.lang.Boolean", defaultValue = "false")
+    public static final String MAVEN_VERSION_RESOLVER_NO_CACHE = "aether.versionResolver.noCache";

Review Comment:
   Agreed. 
   This component is in maven, but implements Resolver API (as Resolver is "incomplete"), but yes, I agree, this is a Maven implementation detail, not resolver.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MNG-8362] Adding some missing config properties [maven]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #1861:
URL: https://github.com/apache/maven/pull/1861#discussion_r1825809861


##########
api/maven-api-core/src/main/java/org/apache/maven/api/Constants.java:
##########
@@ -386,5 +386,26 @@ public final class Constants {
     @Config(type = "java.lang.Boolean", defaultValue = "true")
     public static final String MAVEN_CONSUMER_POM = "maven.consumer.pom";
 
+    /**
+     * User property for disabling version resolver cache.
+     *
+     * @since 3.0.0
+     */
+    @Config(type = "java.lang.Boolean", defaultValue = "false")
+    public static final String MAVEN_VERSION_RESOLVER_NO_CACHE = "aether.versionResolver.noCache";

Review Comment:
   Maybe we can make it start with `maven.` instead of `aether.` to be consistent with all other properties ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org