You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/15 07:11:01 UTC

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #11332: [Improvement][UT] Upgrade jUnit to 5.+ (#10976)

zhongjiajie commented on PR #11332:
URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1214691472

   > > I investigated the migration from `jUnit4` to `jUnit5` in other open-source projects, such as `Apache Flink`. `Apache Flink` community once tried to migrate all stuff from 4 to 5 once for all but finally gave up and decided to do it gradually. Currently, as shown in https://github.com/apache/flink/blob/1232629c80cbb64eb4ca9f6c95d6c5c1a2e8e82d/pom.xml#L147-L148 , they have both versions in the project.
   > > FYI, here is the mailing thread where they discussed about the migration: https://www.mail-archive.com/dev@flink.apache.org/msg47657.html
   > > WDYT @kezhenxu94 @ruanwenjun @caishunfeng @SbloodyS
   > 
   > cc @zhongjiajie
   
   Maybe there are other historical reasons of flink,dolphischeduler do not have many unitest currently, IMO if we can migrate all of them to junit5 now it is the time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org