You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/02/24 22:11:23 UTC
Review Request 43961: Added some additional synchronization in
ROOT_CGROUPS_Pids_and_Tids.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43961/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske, Chi Zhang, Artem Harutyunyan, and Jian Qiu.
Bugs: MESOS-4677
https://issues.apache.org/jira/browse/MESOS-4677
Repository: mesos
Description
-------
Adds a set of pipes to mitigate a race between `exec`ing + updating cgroup tasks and the test reading said cgroup tasks.
Diffs
-----
src/tests/containerizer/isolator_tests.cpp 653b037c489072f43e53dec01a811a9249dcd660
Diff: https://reviews.apache.org/r/43961/diff/
Testing
-------
make check
Centos7: sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_Pids_and_Tids" --gtest_repeat=5000 --gtest_break_on_failure
---
CI results:
sudo make check
| OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | Ubuntu 12 |
Non-SSL | :) | @_@ | * | X_X | :) | :) | :) |
With-SSL | :) | @_@ | * | & | :) | :) | :) |
:) = Passed.
X_X = Configuration error with docker.
@_@ = Ran out of disk space in some tests: LinuxFilesystemIsolatorTest.ROOT_SandboxEnvironmentVariable, LinuxFilesystemIsolatorTest.ROOT_MultipleContainers, MesosContainerizerLaunchTest.ROOT_ChangeRootfs, LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem
* = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes (Known issue)
% = DockerContainerizerTest.ROOT_DOCKER_Logs
Thanks,
Joseph Wu
Re: Review Request 43961: Added some additional synchronization in
ROOT_CGROUPS_Pids_and_Tids.
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43961/#review120648
-----------------------------------------------------------
src/tests/containerizer/isolator_tests.cpp (line 819)
<https://reviews.apache.org/r/43961/#comment182108>
LGTM, Could you help changing the comment here?
- Jian Qiu
On 二月 24, 2016, 9:11 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43961/
> -----------------------------------------------------------
>
> (Updated 二月 24, 2016, 9:11 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Chi Zhang, Artem Harutyunyan, and Jian Qiu.
>
>
> Bugs: MESOS-4677
> https://issues.apache.org/jira/browse/MESOS-4677
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds a set of pipes to mitigate a race between `exec`ing + updating cgroup tasks and the test reading said cgroup tasks.
>
>
> Diffs
> -----
>
> src/tests/containerizer/isolator_tests.cpp 653b037c489072f43e53dec01a811a9249dcd660
>
> Diff: https://reviews.apache.org/r/43961/diff/
>
>
> Testing
> -------
>
> make check
>
> Centos7: sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_Pids_and_Tids" --gtest_repeat=5000 --gtest_break_on_failure
>
> ---
>
> CI results:
>
> sudo make check
>
> | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | Ubuntu 12 |
> Non-SSL | :) | @_@ | * | X_X | :) | :) | :) |
> With-SSL | :) | @_@ | * | & | :) | :) | :) |
>
> :) = Passed.
> X_X = Configuration error with docker.
> @_@ = Ran out of disk space in some tests: LinuxFilesystemIsolatorTest.ROOT_SandboxEnvironmentVariable, LinuxFilesystemIsolatorTest.ROOT_MultipleContainers, MesosContainerizerLaunchTest.ROOT_ChangeRootfs, LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem
>
> * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes (Known issue)
> % = DockerContainerizerTest.ROOT_DOCKER_Logs
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 43961: Added some additional synchronization in
ROOT_CGROUPS_Pids_and_Tids.
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43961/#review120664
-----------------------------------------------------------
Ship it!
Ship It!
- Jian Qiu
On 二月 25, 2016, 5:59 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43961/
> -----------------------------------------------------------
>
> (Updated 二月 25, 2016, 5:59 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Chi Zhang, Artem Harutyunyan, and Jian Qiu.
>
>
> Bugs: MESOS-4677
> https://issues.apache.org/jira/browse/MESOS-4677
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds a set of pipes to mitigate a race between `exec`ing + updating cgroup tasks and the test reading said cgroup tasks.
>
>
> Diffs
> -----
>
> src/tests/containerizer/isolator_tests.cpp 653b037c489072f43e53dec01a811a9249dcd660
>
> Diff: https://reviews.apache.org/r/43961/diff/
>
>
> Testing
> -------
>
> make check
>
> Centos7: sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_Pids_and_Tids" --gtest_repeat=5000 --gtest_break_on_failure
>
> ---
>
> CI results:
>
> sudo make check
>
> | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | Ubuntu 12 |
> Non-SSL | :) | @_@ | * | X_X | :) | :) | :) |
> With-SSL | :) | @_@ | * | & | :) | :) | :) |
>
> :) = Passed.
> X_X = Configuration error with docker.
> @_@ = Ran out of disk space in some tests: LinuxFilesystemIsolatorTest.ROOT_SandboxEnvironmentVariable, LinuxFilesystemIsolatorTest.ROOT_MultipleContainers, MesosContainerizerLaunchTest.ROOT_ChangeRootfs, LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem
>
> * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes (Known issue)
> % = DockerContainerizerTest.ROOT_DOCKER_Logs
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 43961: Added some additional synchronization in
ROOT_CGROUPS_Pids_and_Tids.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43961/#review120683
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer/isolator_tests.cpp (line 813)
<https://reviews.apache.org/r/43961/#comment182141>
"finished exec'ing" reads like "finished executing", i.e. the process has terminated. But that's not what is meant here! Only after I realized this, the sequence of events here became clear to me. Suggestion:
// This observation ensures that the "cat" process
// has completed its part of the exec() procedure
// and is now executing normally."
- Bernd Mathiske
On Feb. 24, 2016, 9:59 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43961/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 9:59 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Chi Zhang, Artem Harutyunyan, and Jian Qiu.
>
>
> Bugs: MESOS-4677
> https://issues.apache.org/jira/browse/MESOS-4677
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds a set of pipes to mitigate a race between `exec`ing + updating cgroup tasks and the test reading said cgroup tasks.
>
>
> Diffs
> -----
>
> src/tests/containerizer/isolator_tests.cpp 653b037c489072f43e53dec01a811a9249dcd660
>
> Diff: https://reviews.apache.org/r/43961/diff/
>
>
> Testing
> -------
>
> make check
>
> Centos7: sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_Pids_and_Tids" --gtest_repeat=5000 --gtest_break_on_failure
>
> ---
>
> CI results:
>
> sudo make check
>
> | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | Ubuntu 12 |
> Non-SSL | :) | @_@ | * | X_X | :) | :) | :) |
> With-SSL | :) | @_@ | * | & | :) | :) | :) |
>
> :) = Passed.
> X_X = Configuration error with docker.
> @_@ = Ran out of disk space in some tests: LinuxFilesystemIsolatorTest.ROOT_SandboxEnvironmentVariable, LinuxFilesystemIsolatorTest.ROOT_MultipleContainers, MesosContainerizerLaunchTest.ROOT_ChangeRootfs, LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem
>
> * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes (Known issue)
> % = DockerContainerizerTest.ROOT_DOCKER_Logs
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 43961: Added some additional synchronization in
ROOT_CGROUPS_Pids_and_Tids.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43961/
-----------------------------------------------------------
(Updated Feb. 24, 2016, 9:59 p.m.)
Review request for mesos, Bernd Mathiske, Chi Zhang, Artem Harutyunyan, and Jian Qiu.
Changes
-------
Update a comment that was left behind from a previous review.
Bugs: MESOS-4677
https://issues.apache.org/jira/browse/MESOS-4677
Repository: mesos
Description
-------
Adds a set of pipes to mitigate a race between `exec`ing + updating cgroup tasks and the test reading said cgroup tasks.
Diffs (updated)
-----
src/tests/containerizer/isolator_tests.cpp 653b037c489072f43e53dec01a811a9249dcd660
Diff: https://reviews.apache.org/r/43961/diff/
Testing
-------
make check
Centos7: sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_Pids_and_Tids" --gtest_repeat=5000 --gtest_break_on_failure
---
CI results:
sudo make check
| OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | Ubuntu 12 |
Non-SSL | :) | @_@ | * | X_X | :) | :) | :) |
With-SSL | :) | @_@ | * | & | :) | :) | :) |
:) = Passed.
X_X = Configuration error with docker.
@_@ = Ran out of disk space in some tests: LinuxFilesystemIsolatorTest.ROOT_SandboxEnvironmentVariable, LinuxFilesystemIsolatorTest.ROOT_MultipleContainers, MesosContainerizerLaunchTest.ROOT_ChangeRootfs, LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem
* = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes (Known issue)
% = DockerContainerizerTest.ROOT_DOCKER_Logs
Thanks,
Joseph Wu
Re: Review Request 43961: Added some additional synchronization in
ROOT_CGROUPS_Pids_and_Tids.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43961/#review120640
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Feb. 24, 2016, 9:11 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43961/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 9:11 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Chi Zhang, Artem Harutyunyan, and Jian Qiu.
>
>
> Bugs: MESOS-4677
> https://issues.apache.org/jira/browse/MESOS-4677
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds a set of pipes to mitigate a race between `exec`ing + updating cgroup tasks and the test reading said cgroup tasks.
>
>
> Diffs
> -----
>
> src/tests/containerizer/isolator_tests.cpp 653b037c489072f43e53dec01a811a9249dcd660
>
> Diff: https://reviews.apache.org/r/43961/diff/
>
>
> Testing
> -------
>
> make check
>
> Centos7: sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_Pids_and_Tids" --gtest_repeat=5000 --gtest_break_on_failure
>
> ---
>
> CI results:
>
> sudo make check
>
> | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | Ubuntu 12 |
> Non-SSL | :) | @_@ | * | X_X | :) | :) | :) |
> With-SSL | :) | @_@ | * | & | :) | :) | :) |
>
> :) = Passed.
> X_X = Configuration error with docker.
> @_@ = Ran out of disk space in some tests: LinuxFilesystemIsolatorTest.ROOT_SandboxEnvironmentVariable, LinuxFilesystemIsolatorTest.ROOT_MultipleContainers, MesosContainerizerLaunchTest.ROOT_ChangeRootfs, LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem
>
> * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes (Known issue)
> % = DockerContainerizerTest.ROOT_DOCKER_Logs
>
>
> Thanks,
>
> Joseph Wu
>
>