You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by tbouron <gi...@git.apache.org> on 2018/05/05 11:06:31 UTC

[GitHub] brooklyn-library pull request #154: Use the settings.xml from Jenkins to dep...

GitHub user tbouron opened a pull request:

    https://github.com/apache/brooklyn-library/pull/154

    Use the settings.xml from Jenkins to deploy artifacts

    Without it, the deploy fails as maven provided by docker doesn't have the right credentials

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tbouron/brooklyn-library feature/docker

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-library/pull/154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #154
    
----
commit dcceb991c1ec07f09d4ce749ab3c1e6e828a46cc
Author: Thomas Bouron <th...@...>
Date:   2018-05-05T11:03:45Z

    Use the settings.xml from Jenkins to deploy artifacts

----


---

[GitHub] brooklyn-library issue #154: Use the settings.xml from Jenkins to deploy art...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-library/pull/154
  
    retest this please


---

[GitHub] brooklyn-library issue #154: Use the settings.xml from Jenkins to deploy art...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-library/pull/154
  
    retest this please
    
    (just using this to test https://builds.apache.org/view/B/view/Brooklyn/job/brooklyn-library-pull-requests-pipeline/)


---

[GitHub] brooklyn-library issue #154: Use the settings.xml from Jenkins to deploy art...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:

    https://github.com/apache/brooklyn-library/pull/154
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/brooklyn-library-pull-requests-pipeline/2/



---

[GitHub] brooklyn-library issue #154: Use the settings.xml from Jenkins to deploy art...

Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the issue:

    https://github.com/apache/brooklyn-library/pull/154
  
    retest this please


---

[GitHub] brooklyn-library issue #154: Use the settings.xml from Jenkins to deploy art...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:

    https://github.com/apache/brooklyn-library/pull/154
  
    Can one of the admins verify this patch?


---

[GitHub] brooklyn-library issue #154: Use the settings.xml from Jenkins to deploy art...

Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the issue:

    https://github.com/apache/brooklyn-library/pull/154
  
    @aledsage This one is now invalid since you changed the `Jenkinsfile`. Actually, I think it's not needed anymore


---

[GitHub] brooklyn-library issue #154: Use the settings.xml from Jenkins to deploy art...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-library/pull/154
  
    @tbouron I think you're right that we don't need this PR - for example, https://builds.apache.org/job/brooklyn-library-master-docker/335 passed and its console output included:
    
    ```
    Uploading to apache.snapshots.https: https://repository.apache.org/content/repositories/snapshots/org/apache/brooklyn/brooklyn-library-catalog/1.0.0-SNAPSHOT/brooklyn-library-catalog-1.0.0-20180924.134212-335.jar
    Progress (1): 2.0/8.0 kB
    Progress (1): 4.1/8.0 kB
    Progress (1): 6.1/8.0 kB
    Progress (1): 8.0 kB    
                        
    Uploaded to apache.snapshots.https: https://repository.apache.org/content/repositories/snapshots/org/apache/brooklyn/brooklyn-library-catalog/1.0.0-SNAPSHOT/brooklyn-library-catalog-1.0.0-20180924.134212-335.jar (8.0 kB at 9.4 kB/s)
    ```
    
    However, I'm not sure what will happen after we merge https://github.com/apache/brooklyn-library/pull/160 (so no longer mount the host's .m2 directory). We might need to mount the `settings.xml` file read-only.


---