[GitHub] [spark] LuciferYang commented on pull request #38960: [SPARK-41435][SQL] Make `curdate()` throw `WRONG_NUM_ARGS ` when args is not empty

[GitBox <gi...@apache.org>]

LuciferYang commented on PR #38960:
URL: https://github.com/apache/spark/pull/38960#issuecomment-1341907393

   There are two questions:
   1.  When `validParametersCount.length == 0`, should an internal exception be thrown? I think `validParametersCount.length == 0` should only be because it does not match the appropriate constructor, as I described in https://github.com/apache/spark/pull/38940#discussion_r1041778431.
   
   3. `select curdate(1)` looks like a user usage exception. I don't think it should enter the `validParametersCount.length == 0` branch
   
   I think deleting remove the error class and returning an internal error should be completed in https://github.com/apache/spark/pull/38940.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org