You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Swaroopa Kadam (JIRA)" <ji...@apache.org> on 2019/03/20 22:12:00 UTC
[jira] [Commented] (PHOENIX-5204) Breaking UpsertCompiler#compile
function into small readable functions
[ https://issues.apache.org/jira/browse/PHOENIX-5204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797608#comment-16797608 ]
Swaroopa Kadam commented on PHOENIX-5204:
-----------------------------------------
[~jamestaylor] I hope it is not too late to do this? I would like to improve this method. What do you suggest?
> Breaking UpsertCompiler#compile function into small readable functions
> ----------------------------------------------------------------------
>
> Key: PHOENIX-5204
> URL: https://issues.apache.org/jira/browse/PHOENIX-5204
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.14.1
> Reporter: Swaroopa Kadam
> Assignee: Swaroopa Kadam
> Priority: Minor
>
> Currently, UpsertCompile#compile method is ~500 lines and does multiple things listed below:
> # Upsert Select
> # Upsert Select (Client/Server side)
> # Upsert Values
> It would be better and cleaner to break the method into logically smaller and more readable methods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)