You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2019/06/25 15:19:15 UTC

[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth 

Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13723


Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth
......................................................................

IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth

Switch to a newer version of CDP Hive where HIVE-20833 is reverted.
HIVE-20833 was backported without HIVE-20221, which broke the
the handling of column PARTITION_PARAMS.PARAM_KEY in HMS, leading
to several test failures in Impala.

The new HIVE version also includes the fix for HIVE-21796, so
test_max_nesting_depth could be also re-enabled with Hive 3.

Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92
---
M bin/impala-config.sh
M tests/common/skip.py
M tests/query_test/test_nested_types.py
3 files changed, 6 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/13723/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92
Gerrit-Change-Number: 13723
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>

[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 )

Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92
Gerrit-Change-Number: 13723
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 23:20:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 )

Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/3737/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92
Gerrit-Change-Number: 13723
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 15:59:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 )

Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4536/


-- 
To view, visit http://gerrit.cloudera.org:8080/13723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92
Gerrit-Change-Number: 13723
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 22:24:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 )

Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4536/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/13723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92
Gerrit-Change-Number: 13723
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 16:05:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 )

Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92
Gerrit-Change-Number: 13723
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 05:03:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 )

Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4556/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/13723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92
Gerrit-Change-Number: 13723
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 23:19:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 )

Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4549/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/13723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92
Gerrit-Change-Number: 13723
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 12:21:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 )

Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4550/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/13723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92
Gerrit-Change-Number: 13723
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 13:29:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 )

Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92
Gerrit-Change-Number: 13723
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 15:03:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13723 )

Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth
......................................................................

IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth

Switch to a newer version of CDP Hive where HIVE-20833 is reverted.
HIVE-20833 was backported without HIVE-20221, which broke the
the handling of column PARTITION_PARAMS.PARAM_KEY in HMS, leading
to several test failures in Impala.

The new HIVE version also includes the fix for HIVE-21796, so
test_max_nesting_depth could be also re-enabled with Hive 3.

Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92
Reviewed-on: http://gerrit.cloudera.org:8080/13723
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
M tests/common/skip.py
M tests/query_test/test_nested_types.py
3 files changed, 6 insertions(+), 10 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92
Gerrit-Change-Number: 13723
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 )

Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4550/


-- 
To view, visit http://gerrit.cloudera.org:8080/13723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92
Gerrit-Change-Number: 13723
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 19:09:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8369: Bump CDP BUILD NUMBER and re-enable test max nesting depth

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13723 )

Change subject: IMPALA-8369: Bump CDP_BUILD_NUMBER and re-enable test_max_nesting_depth
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4557/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d6f4e29997c9cf2238e1d614f8d1ed7d35ffe92
Gerrit-Change-Number: 13723
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 23:20:04 +0000
Gerrit-HasComments: No