You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/05/02 01:51:32 UTC

[GitHub] [hadoop-thirdparty] medb opened a new pull request #13: HADOOP-17679. Upgrade Protobuf to 3.12.4

medb opened a new pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13


   Protobuf 3.7.1 is not available in any OS repo and requires manual compilation which takes time (10-15 mins).
   
   Protobuf 3.12.4 is not only newer but also available in latest Debian and Ubuntu release out of the box which eliminates need for manual compilation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org

[GitHub] [hadoop-thirdparty] medb commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.0

Posted by GitBox <gi...@apache.org>.
medb commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840985181


   @jojochuang rebased on the trunk HEAD and updated PR to the latest Protobuf version


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.0

Posted by GitBox <gi...@apache.org>.
jojochuang commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-842024117


   As I said, this PR is not needed. I'd like to ask you to work on the protobuf update in the main hadoop repository.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.12.4

Posted by GitBox <gi...@apache.org>.
jojochuang commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840251431


   Instead, we should do this for the main hadoop repository, not the hadoop-thirdparty repo. https://github.com/apache/hadoop/blob/trunk/dev-support/docker/Dockerfile#L120


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org

[GitHub] [hadoop-thirdparty] medb commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.3

Posted by GitBox <gi...@apache.org>.
medb commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-912924915


   @jojochuang sent PR to the Hadoop repo: https://github.com/apache/hadoop/pull/3384
   
   Please, let me know if this is correct.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.12.4

Posted by GitBox <gi...@apache.org>.
jojochuang commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840250988


   So at the end of the day, we probably don't need to use protobuf in the hadoop-thirdparty repository. See: https://github.com/apache/hadoop-thirdparty/pull/14#discussion_r631520733


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org

[GitHub] [hadoop-thirdparty] medb commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.12.4

Posted by GitBox <gi...@apache.org>.
medb commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840254235


   @jojochuang May you clarify, do you mean that we do not need to compile protoc in [`hadoop-thirdparty` Docker file](https://github.com/apache/hadoop-thirdparty/blob/trunk/dev-support/docker/Dockerfile)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.12.4

Posted by GitBox <gi...@apache.org>.
jojochuang commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-840256223


   Yeah. We have a number of redundant steps in hadoop-thirdparty Dockerfile. It was copied from the main hadoop repo but we don't need many of the packages.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org

[GitHub] [hadoop-thirdparty] medb edited a comment on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.3

Posted by GitBox <gi...@apache.org>.
medb edited a comment on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-913062242


   @jojochuang I took a look at Hadoop changes in apache/hadoop#3384, and it seems that to upgrade Protobuf both PRs are required (apache/hadoop-thirdparty#13 in `hadoop-thirdparty` and apache/hadoop#3384 in `hadoop` repositories)
   
   May you explain, how can I update Protobuf without any changes in Hadoop Thirdparty repository (i.e. this PR)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org

[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.0

Posted by GitBox <gi...@apache.org>.
jojochuang commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-842024117


   As I said, this PR is not needed. I'd like to ask you to work on the protobuf update in the main hadoop repository.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org

[GitHub] [hadoop-thirdparty] medb commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.3

Posted by GitBox <gi...@apache.org>.
medb commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-913062242


   @jojochuang I took a look at Hadoop changes, and it seems to upgrade Protobuf both PRs are necessary (in `hadoop-thirdparty` and `hadoop` repositories)
   
   May you explain, how can I update Protobuf without any changes in Hadoop Thirdparty repository (i.e. this PR)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org

[GitHub] [hadoop-thirdparty] cjolivier01 commented on pull request #13: HADOOP-17679. Upgrade Protobuf to 3.17.3

Posted by GitBox <gi...@apache.org>.
cjolivier01 commented on pull request #13:
URL: https://github.com/apache/hadoop-thirdparty/pull/13#issuecomment-1050314164


   It would be good to update this to a non-vulnerable version of protobuf


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org