You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by ad...@apache.org on 2017/09/01 23:52:30 UTC
kudu git commit: java: clarify the use of several compile scopes
Repository: kudu
Updated Branches:
refs/heads/master 311755895 -> e0cd85e24
java: clarify the use of several compile scopes
After some testing, we've learned that parquet-hadoop and sparkavro should
be in the compile scope because it's pretty rare to see them provided by
platform providers. I added some comments to help clarify this.
Change-Id: I2218d1e886e5dd7fb300218402622056342d4cae
Reviewed-on: http://gerrit.cloudera.org:8080/7944
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/e0cd85e2
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/e0cd85e2
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/e0cd85e2
Branch: refs/heads/master
Commit: e0cd85e24b8cf7a1accffa6d7e25e65d1bd774b9
Parents: 3117558
Author: Adar Dembo <ad...@cloudera.com>
Authored: Fri Sep 1 14:46:47 2017 -0700
Committer: Adar Dembo <ad...@cloudera.com>
Committed: Fri Sep 1 23:52:05 2017 +0000
----------------------------------------------------------------------
java/kudu-client-tools/build.gradle | 6 +++++-
java/kudu-client-tools/pom.xml | 21 ++++++++++++---------
java/kudu-spark-tools/build.gradle | 5 ++++-
java/kudu-spark-tools/pom.xml | 13 ++++++++-----
4 files changed, 29 insertions(+), 16 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/e0cd85e2/java/kudu-client-tools/build.gradle
----------------------------------------------------------------------
diff --git a/java/kudu-client-tools/build.gradle b/java/kudu-client-tools/build.gradle
index fd04772..b409491 100644
--- a/java/kudu-client-tools/build.gradle
+++ b/java/kudu-client-tools/build.gradle
@@ -19,7 +19,11 @@ apply from: "$rootDir/gradle/shadow.gradle"
dependencies {
compile project(":kudu-mapreduce")
+
+ // This artifact is in compile scope for convenience, as it is typically
+ // not included in the job classpath by MapReduce platform providers.
compile libs.parquetHadoop
+
compile libs.yetusAnnotations
compile libs.slf4jApi
@@ -30,4 +34,4 @@ dependencies {
testCompile libs.junit
testCompile libs.log4j
testCompile libs.slf4jLog4j12
-}
\ No newline at end of file
+}
http://git-wip-us.apache.org/repos/asf/kudu/blob/e0cd85e2/java/kudu-client-tools/pom.xml
----------------------------------------------------------------------
diff --git a/java/kudu-client-tools/pom.xml b/java/kudu-client-tools/pom.xml
index 301c263..95dda53 100644
--- a/java/kudu-client-tools/pom.xml
+++ b/java/kudu-client-tools/pom.xml
@@ -47,11 +47,19 @@
<version>${slf4j.version}</version>
</dependency>
+ <!-- This artifact is in compile scope for convenience, as it is typically
+ not included in the job classpath by MapReduce platform providers. -->
<dependency>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-client</artifactId>
- <version>${hadoop.version}</version>
- <scope>provided</scope>
+ <groupId>org.apache.parquet</groupId>
+ <artifactId>parquet-hadoop</artifactId>
+ <version>${parquet.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-client</artifactId>
+ <version>${hadoop.version}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
@@ -86,11 +94,6 @@
<version>${slf4j.version}</version>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.apache.parquet</groupId>
- <artifactId>parquet-hadoop</artifactId>
- <version>${parquet.version}</version>
- </dependency>
</dependencies>
<build>
http://git-wip-us.apache.org/repos/asf/kudu/blob/e0cd85e2/java/kudu-spark-tools/build.gradle
----------------------------------------------------------------------
diff --git a/java/kudu-spark-tools/build.gradle b/java/kudu-spark-tools/build.gradle
index 8bb0315..c45b710 100644
--- a/java/kudu-spark-tools/build.gradle
+++ b/java/kudu-spark-tools/build.gradle
@@ -23,6 +23,9 @@ dependencies {
compile project(path: ":kudu-client-tools", configuration: "shadow")
compile project(path: ":kudu-spark", configuration: "shadow")
compile libs.slf4jApi
+
+ // This artifact is in compile scope for convenience, as it is typically
+ // not included in the Spark submit classpath by Spark platform providers.
compile libs.sparkAvro
provided libs.scalaLibrary
@@ -38,4 +41,4 @@ dependencies {
}
// Adjust the artifact name to match the maven build.
-archivesBaseName = "kudu-spark${versions.sparkBase}-tools_${versions.scalaBase}"
\ No newline at end of file
+archivesBaseName = "kudu-spark${versions.sparkBase}-tools_${versions.scalaBase}"
http://git-wip-us.apache.org/repos/asf/kudu/blob/e0cd85e2/java/kudu-spark-tools/pom.xml
----------------------------------------------------------------------
diff --git a/java/kudu-spark-tools/pom.xml b/java/kudu-spark-tools/pom.xml
index 64bfb26..97a3b44 100644
--- a/java/kudu-spark-tools/pom.xml
+++ b/java/kudu-spark-tools/pom.xml
@@ -53,6 +53,14 @@
<version>${slf4j.version}</version>
</dependency>
+ <!-- This artifact is in compile scope for convenience, as it is typically
+ not included in the Spark submit classpath by Spark platform providers. -->
+ <dependency>
+ <groupId>com.databricks</groupId>
+ <artifactId>spark-avro_${scala.binary.version}</artifactId>
+ <version>${sparkavro.version}</version>
+ </dependency>
+
<dependency>
<groupId>org.apache.spark</groupId>
<artifactId>spark-core_${scala.binary.version}</artifactId>
@@ -99,11 +107,6 @@
<scope>test</scope>
</dependency>
<dependency>
- <groupId>com.databricks</groupId>
- <artifactId>spark-avro_${scala.binary.version}</artifactId>
- <version>${sparkavro.version}</version>
- </dependency>
- <dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>${junit.version}</version>