[GitHub] [iceberg] alaturqua commented on a diff in pull request #6970: Python: Fix ADLS configuration

["alaturqua (via GitHub)" <gi...@apache.org>]

alaturqua commented on code in PR #6970:
URL: https://github.com/apache/iceberg/pull/6970#discussion_r1122763057


##########
python/tests/conftest.py:
##########
@@ -1277,8 +1277,8 @@ def adlfs_fsspec_fileio(request: pytest.FixtureRequest) -> Generator[FsspecFileI
     azurite_account_key = request.config.getoption("--adlfs.account-key")
     azurite_connection_string = f"DefaultEndpointsProtocol=http;AccountName={azurite_account_name};AccountKey={azurite_account_key};BlobEndpoint={azurite_url}/{azurite_account_name};"
     properties = {
-        "connection_string": azurite_connection_string,
-        "account_name": azurite_account_name,
+        "adlfs.connection-string": azurite_connection_string,
+        "adlfs.account-name": azurite_account_name,

Review Comment:
   @Fokko 
   
   I believe the simplest approach would be to utilize connection-string, as it can accommodate various possibilities such as a SAS Token. 
   
   For example Trino/Starburst uses account-name and access-key  Azure Storage.
   Check please Hive Connector with Azure Storage in Trino as reference.
   https://trino.io/docs/current/connector/hive-azure.html#
   
   Based on the information provided, my recommendation would be to allow for both a connection-string or an account-name and account-key to be used. This would provide flexibility for users who may prefer one method over the other.
   
   
   For the Azure Storage URL's there are following possibilites. I guess this is for the other PR relevant.
   
   - abfs
   - abfss
   - wasb 
   - wasbs
   - adl



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org