[GitHub] [flink] BryceCicada edited a comment on pull request #12824: [FLINK-18488][python] Added additional params to CsvTableSource constructor

[GitBox <gi...@apache.org>]

BryceCicada edited a comment on pull request #12824:
URL: https://github.com/apache/flink/pull/12824#issuecomment-654121466


   @dianfu Thanks.
   
   > Should we also support emptyColumnAsNull?
   
   Yeah... from the Java side, I think some small mismatch between the CsvTableSource constructor and builder has crept in:
     - The builder allows emptyColumnAsNull, but the constructors do not.
     - There's one constructor that allows selectedFields, but the builder does not.
   
   If I add emptyColumnAsNull to Python constructor, it'll make the Python constructor match none of the Java constructors. My initial thoughts were that it would be a little jarring.  On the other-hand, without it we're depriving python users of the feature.  So yeah, I agree... we should add it here.  
   
   I'll raise another Jira ticket describing the Java constructor/builder thing and request it's assigned to me.  Once that's implemented, the Python and Java constructors should match.
   
   > Besides, there are checkstyle issues which should be addressed.
   
   Thanks, I've just seen how to run these and I see what you mean.  Will fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org