You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/05 23:38:57 UTC
[GitHub] [spark] gengliangwang opened a new pull request #27816:
[SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
gengliangwang opened a new pull request #27816: [SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
URL: https://github.com/apache/spark/pull/27816
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add `OrcV2QuerySuite` which explicitly sets the configuration `USE_V1_SOURCE_LIST` as `""` to use ORC V2 implementation.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
As now file source V2 is disabled by default, the test suite `OrcQuerySuite` is testing V1 implementation as well as the `OrcV1QuerySuite`. We should fix it.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27816:
[SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27816: [SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
URL: https://github.com/apache/spark/pull/27816#issuecomment-595605589
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27816:
[SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27816: [SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
URL: https://github.com/apache/spark/pull/27816#issuecomment-595500252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24163/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27816:
[SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27816: [SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
URL: https://github.com/apache/spark/pull/27816#issuecomment-595605037
**[Test build #119427 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119427/testReport)** for PR 27816 at commit [`fe64572`](https://github.com/apache/spark/commit/fe64572354d6c9aec392f46ed236e8184572e147).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `abstract class OrcQuerySuite extends OrcQueryTest with SharedSparkSession `
* `class OrcV2QuerySuite extends OrcQuerySuite `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27816:
[SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27816: [SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
URL: https://github.com/apache/spark/pull/27816#issuecomment-595500246
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27816:
[SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27816: [SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
URL: https://github.com/apache/spark/pull/27816#issuecomment-595500246
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27816:
[SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27816: [SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
URL: https://github.com/apache/spark/pull/27816#issuecomment-595502184
**[Test build #119427 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119427/testReport)** for PR 27816 at commit [`fe64572`](https://github.com/apache/spark/commit/fe64572354d6c9aec392f46ed236e8184572e147).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27816:
[SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27816: [SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
URL: https://github.com/apache/spark/pull/27816#issuecomment-595500252
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24163/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27816:
[SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27816: [SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
URL: https://github.com/apache/spark/pull/27816#issuecomment-595502184
**[Test build #119427 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119427/testReport)** for PR 27816 at commit [`fe64572`](https://github.com/apache/spark/commit/fe64572354d6c9aec392f46ed236e8184572e147).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27816:
[SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27816: [SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
URL: https://github.com/apache/spark/pull/27816#issuecomment-595605589
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #27816:
[SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27816: [SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
URL: https://github.com/apache/spark/pull/27816
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27816:
[SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27816: [SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
URL: https://github.com/apache/spark/pull/27816#issuecomment-595605592
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119427/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27816:
[SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27816: [SPARK-23817][FollowUp][Test] Add OrcV2QuerySuite
URL: https://github.com/apache/spark/pull/27816#issuecomment-595605592
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119427/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org