You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2023/07/04 12:51:05 UTC
[GitHub] [arrow] pitrou opened a new pull request, #36454: GH-36452: [CI][C++] Test C++20 support with compatible compiler
pitrou opened a new pull request, #36454:
URL: https://github.com/apache/arrow/pull/36454
We were testing C++20 compatibility on a gcc version that only accepts `-std=c++2a`, not `-std=c++20`. Switch to a newer Ubuntu, and therefore gcc, version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36454: GH-36452: [CI][C++] Test C++20 support with compatible compiler
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36454:
URL: https://github.com/apache/arrow/pull/36454#issuecomment-1620198786
Revision: 8e9df216c1e3ba2e70fe6c9f682f1bbcf275f582
Submitted crossbow builds: [ursacomputing/crossbow @ actions-203c96dc73](https://github.com/ursacomputing/crossbow/branches/all?query=actions-203c96dc73)
|Task|Status|
|----|------|
|test-ubuntu-22.04-cpp-20|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-203c96dc73-github-test-ubuntu-22.04-cpp-20)](https://github.com/ursacomputing/crossbow/actions/runs/5454932105/jobs/9925696827)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36454: GH-36452: [CI][C++] Test C++20 support with compatible compiler
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36454:
URL: https://github.com/apache/arrow/pull/36454#issuecomment-1620829109
It's #36257 but nobody works on it because it's not reproduced on local...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #36454: GH-36452: [CI][C++] Test C++20 support with compatible compiler
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #36454:
URL: https://github.com/apache/arrow/pull/36454#issuecomment-1620198069
@kou Do you understand the "Archery & Crossbow" CI failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #36454: GH-36452: [CI][C++] Test C++20 support with compatible compiler
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #36454:
URL: https://github.com/apache/arrow/pull/36454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #36454: GH-36452: [CI][C++] Test C++20 support with compatible compiler
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #36454:
URL: https://github.com/apache/arrow/pull/36454#issuecomment-1620194802
@github-actions crossbow submit *-cpp-20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36454: GH-36452: [CI][C++] Test C++20 support with compatible compiler
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36454:
URL: https://github.com/apache/arrow/pull/36454#issuecomment-1627372464
Conbench analyzed the 6 benchmark runs on commit `7ecec6c8`.
There were 3 benchmark results indicating a performance regression:
- Commit Run on `ursa-thinkcentre-m75q` at [2023-07-06 04:22:30Z](http://conbench.ursa.dev/compare/runs/c6ef04156dc347c78889e482c1ed7b2c...efc2f6edcbd142168225e9dd1b9d35ef/)
- [params=1048576/100, source=cpp-micro, suite=arrow-acero-aggregate-benchmark](http://conbench.ursa.dev/compare/benchmarks/064a61a0157d7b7c800012beee98d0fc...064a641b02ba735180008da19587ca0b)
- [params=<SMALL_VECTOR(int)>, source=cpp-micro, suite=arrow-small-vector-benchmark](http://conbench.ursa.dev/compare/benchmarks/064a61a169fd791b8000791038494074...064a641c4f0b7a08800087ff32aea395)
- and 1 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/14880350310) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org